Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Energy Skate Park: Basics #751

Closed
samreid opened this issue Dec 8, 2016 · 8 comments
Closed

Test Energy Skate Park: Basics #751

samreid opened this issue Dec 8, 2016 · 8 comments

Comments

@samreid
Copy link
Member

samreid commented Dec 8, 2016

Internal renaming of variables was done in phetsims/energy-skate-park-basics#358 and in phetsims/energy-skate-park-basics#358 (comment) we decided it would be nice to test it out and make sure all is well.

Link:
http://www.colorado.edu/physics/phet/dev/html/energy-skate-park-basics/1.2.4-dev.3/energy-skate-park-basics_en.html

Tests only need to be run on one platform, because they are logic issues. We are looking for incorrect behavior related to the skater physics, which may manifest as the skater stopping, falling through track, or the application crashing (due to undefined value access). Assigned to @ariel-phet for priority and reassignment.

Please reassign phetsims/energy-skate-park-basics#358 to me after testing completes.

@ariel-phet
Copy link

Marking low priority at the moment since we have more urgent needs in the testing hopper, will bump up as priorities allow.

@ariel-phet ariel-phet assigned phet-steele and unassigned ariel-phet Dec 9, 2016
@ariel-phet
Copy link

@phet-steele perhaps @maggiewiseman would be willing to work on this issue as it is quite stale

@phet-steele
Copy link

@samreid is the link above still viable to be tested, or do we need a more updated link?

@phet-steele phet-steele assigned samreid and unassigned phet-steele Apr 17, 2017
@samreid
Copy link
Member Author

samreid commented Apr 18, 2017

Since these are sim-specific logic issues and one-platform testing, the link above is still good.

@samreid samreid assigned phet-steele and unassigned samreid Apr 18, 2017
@phet-steele
Copy link

Alright, thanks @samreid. @maggiewiseman, can you look into this testing? Read the first post for the details.

@maggiewiseman
Copy link

yes! Will check it out @phet-steele later tonight!

@maggiewiseman
Copy link

@phet-steele @samreid I played with the sim for about 4 hours over the last few days. Other than the two minor issues I submitted (368 and 369), I could not find anything wrong. All seemed to be working as expected.

@samreid
Copy link
Member Author

samreid commented Apr 24, 2017

Excellent, thanks @maggiewiseman. It seems like no new bugs were introduced in the refactoring so this issue can be closed. We will continue with #368 and #369 separately.

@samreid samreid closed this as completed Apr 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants