-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test Energy Skate Park: Basics #751
Comments
Marking low priority at the moment since we have more urgent needs in the testing hopper, will bump up as priorities allow. |
@phet-steele perhaps @maggiewiseman would be willing to work on this issue as it is quite stale |
@samreid is the link above still viable to be tested, or do we need a more updated link? |
Since these are sim-specific logic issues and one-platform testing, the link above is still good. |
Alright, thanks @samreid. @maggiewiseman, can you look into this testing? Read the first post for the details. |
yes! Will check it out @phet-steele later tonight! |
@phet-steele @samreid I played with the sim for about 4 hours over the last few days. Other than the two minor issues I submitted (368 and 369), I could not find anything wrong. All seemed to be working as expected. |
Excellent, thanks @maggiewiseman. It seems like no new bugs were introduced in the refactoring so this issue can be closed. We will continue with #368 and #369 separately. |
Internal renaming of variables was done in phetsims/energy-skate-park-basics#358 and in phetsims/energy-skate-park-basics#358 (comment) we decided it would be nice to test it out and make sure all is well.
Link:
http://www.colorado.edu/physics/phet/dev/html/energy-skate-park-basics/1.2.4-dev.3/energy-skate-park-basics_en.html
Tests only need to be run on one platform, because they are logic issues. We are looking for incorrect behavior related to the skater physics, which may manifest as the skater stopping, falling through track, or the application crashing (due to undefined value access). Assigned to @ariel-phet for priority and reassignment.
Please reassign phetsims/energy-skate-park-basics#358 to me after testing completes.
The text was updated successfully, but these errors were encountered: