-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skater falls through track when dropped from various heights when x = 4.5 to 5 m on quarter pipe ramp option #369
Comments
I reproduced the problem, @ariel-phet can you prioritize? |
Nice catch @maggiewiseman! Since this bug exists in the published version (but does not seem to have caused major issues), I am going to mark priority deferred until we revisit this sim (likely when we make the full version) |
I also found this problem on my macOS 10.13.5 + all browsers. It seems like the skater will fall through the track whenever she is dropped on the portion of the track that is in close proximity to the ground. This occurred in the Intro, Friction, and Playground screen. Noticed while doing testing for phetsims/qa/issues/134. |
Perhaps if the skater crosses both the ground and the track in the same time step, the code currently doesn't check which the skater crossed first. |
This is a duplicate of phetsims/energy-skate-park#159, closing this issue. #369 (comment) was also suggested there. |
Test device: Mac Airbook
Operating System: Sierra 10.12.4
Browser: Chrome Version 57.0.2987.133 (64-bit)
Problem description:
Skater falls through track when dropped precisely from position (5,3) on graph (3 meters up, 5 boxes to the right from the origin. If skater is dropped at (5, 2) or (5, 4) she follows the ramp as expected. Generally, the sim is just inconsistent around x = 4.5 to 5 m. At certain heights she falls through the track and at other heights above and below a given point she will follow the track.
I also tested in the live version and it has the same bug.
Steps to reproduce:
Screenshots:
Related to:
phetsims/tasks#751
Troubleshooting information (do not edit):
Name: Energy Skate Park: Basics
URL: https://phet.colorado.edu/sims/html/energy-skate-park-basics/latest/energy-skate-park-basics_en.html
Version: 1.1.5 2017-04-16 06:50:05 UTC
Features missing: touch
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/57.0.2987.133 Safari/537.36
Language: en-US
Window: 1317x1041
Pixel Ratio: 1/1
WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium)
GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium)
Vendor: WebKit (WebKit WebGL)
Vertex: attribs: 16 varying: 15 uniform: 1024
Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 80)
Max viewport: 16384x16384
OES_texture_float: true
Dependencies JSON: {"assert":{"sha":"7d27130a","branch":"HEAD"},"axon":{"sha":"084c71cf","branch":"HEAD"},"babel":{"sha":"02e6456f","branch":"master"},"brand":{"sha":"ae19edf4","branch":"HEAD"},"chipper":{"sha":"97148ee1","branch":"HEAD"},"dot":{"sha":"33ae235e","branch":"HEAD"},"energy-skate-park-basics":{"sha":"7dcd05e5","branch":"HEAD"},"joist":{"sha":"2f8a4836","branch":"HEAD"},"kite":{"sha":"24ad131a","branch":"HEAD"},"phet-core":{"sha":"c48bf320","branch":"HEAD"},"phetcommon":{"sha":"64051904","branch":"HEAD"},"scenery":{"sha":"4c1b5315","branch":"HEAD"},"scenery-phet":{"sha":"71c5dea5","branch":"HEAD"},"sherpa":{"sha":"2b2bdfd9","branch":"HEAD"},"sun":{"sha":"953074cc","branch":"HEAD"},"tandem":{"sha":"2441eec6","branch":"HEAD"}}
The text was updated successfully, but these errors were encountered: