Skater tandem names don't match their associated Property names

[pixelzoom]

Noted while working on https://github.com/phetsims/phet-io/issues/661.

Skater has many tandem names that don't match their associated Property names (which is supposed to be the case, by convention.) This made it significantly more difficult to convert.

[pixelzoom]

All such Properties are marked with a TODO item that references this issue.

[samreid]

Marked for phet-io meeting to decide on the variable names.

[samreid]

We decided to use shorter but not cryptic names, like parametricPosition and parametricSpeed. @samreid should take care of this.

[samreid]

Fixed above and tested for about 5 minutes. This was an invasive change and possible that I've missed some situations. @ariel-phet I recommend that this be more thoroughly tested by the QA team before we publish another version out of master. It can be tested directly from phettest, or we can create a dev publication for testing. Reassigned to @ariel-phet for feedback.

[ariel-phet]

@samreid yes, please create a dev version, also create a test task with some context description (and perhaps some things that might be good to look out for). Please assign the test task to me at first.

[marlitas]

This will be tested as part of the upcoming region and culture publication.

[arouinfar]

This will be tested as part of the upcoming region and culture publication.

@marlitas are you sure? PhET-iO instrumentation of this sim is ancient (instance proxies) and isn't part of the Hydrogen set. If we redeploy ESPB from main as part of the localization work, I strongly recommend it is only phet-brand.

[marlitas]

Ahhh I did not know this, thanks for the heads up @arouinfar. @kathy-phet this sounds like we will not include phet-io work for region and culture publications then?

[marlitas]

PhET-iO brand is not included in the upcoming region and culture publication. Marking as deferred.