Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a pane system for pop ups and dialogs #347

Open
jessegreenberg opened this issue Mar 29, 2018 · 2 comments
Open

Create a pane system for pop ups and dialogs #347

jessegreenberg opened this issue Mar 29, 2018 · 2 comments

Comments

@jessegreenberg
Copy link
Contributor

Mostly in support of #359 (dialogs), but can be used for other things too. For that issue I made a prototype for managing dialogs in a "pane" system. This is as far as I got

PaneLayer: A layer that manages node siblings. Moves nodes to the front depending on user interaction, manages addition and removal of nodes. It is the client's responsibility to add the layer to the correct place in the scene graph.
topPane: A singleton type with one PaneLayer. Meant to always be on top. Is a singleton so that it is easy to add items to the top of the view through something like topPane.addToFront( node ).

I am not wed to the terminology and type names, but is just for brainstorming.

Sim.js was responsible for adding the topPane layer to the scene graph. Otherwise, a PaneLayer can be added anywhere.

Pretty simple, but I will commit to a branch and assign to @andrea-phet, it may be a stepping stone as she continues work on Dialogs.

@pixelzoom
Copy link
Contributor

Reassigning to @ariel-phet for prioritization and assignment.

@ariel-phet
Copy link

This work is not currently a priority for the project, and it is unclear when it will be picked up again. Marking deferred.

@ariel-phet ariel-phet removed their assignment Nov 19, 2020
@zepumph zepumph added the Epic label Jan 28, 2021
@samreid samreid added type:epic and removed Epic labels Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants