Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reuse sun.ComboBox's list to implement joist.PhetMenu #18

Closed
pixelzoom opened this issue Jul 2, 2013 · 2 comments
Closed

reuse sun.ComboBox's list to implement joist.PhetMenu #18

pixelzoom opened this issue Jul 2, 2013 · 2 comments

Comments

@pixelzoom
Copy link
Contributor

Will need to factor out the list and add support for separators. ListNode will live in sun.

@samreid
Copy link
Member

samreid commented Oct 8, 2014

In my opinion, the popup PhetMenu should share code with other dialogs such as in #166. Many of the same issues apply, such as appearing over everything (z-order), appearing at the right location and updating location when the window bounds change. Perhaps we should look into this then?

@pixelzoom
Copy link
Contributor Author

This functionality doesn't belong in joist. It will (someday) be handled more generally in phetsims/sun#347 ("Create a pane system for pop ups and dialogs").

Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants