Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert to one of the ZoomButtonGroup subclasses #352

Closed
pixelzoom opened this issue Feb 25, 2021 · 1 comment
Closed

Convert to one of the ZoomButtonGroup subclasses #352

pixelzoom opened this issue Feb 25, 2021 · 1 comment
Assignees
@jbphet

Comments

@pixelzoom
Copy link
Contributor

From phetsims/scenery-phet#652, this sim is a candidate for converting to one of the ZoomButtonGroup subclasses. The Buttons screen of the scenery-phet demo shows the 2 subclasses (screenshot below), PlusMinusZoomButtonGroup on the left, MagnifyingGlassZoomButtonGroup. If you don't want to change the look of the sim, use MagnifyingGlassZoomButtonGroup. If you think the more modern-looking PlusMinusZoomButtonGroup is more appropriate, consult with your sim designer.

screenshot_882
jbphet added a commit that referenced this issue Apr 5, 2021
@jbphet
converted zoom buttons to use a zoom button group, see #352
bcfb6da
@jbphet
Copy link
Contributor

jbphet commented Apr 5, 2021

Done, closing.

@jbphet jbphet closed this as completed Apr 5, 2021
@jbphet jbphet mentioned this issue Apr 5, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jbphet jbphet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pixelzoom @jbphet