You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've noticed this before, but it became painfully apparent while working on #352. The inheritance hierarchy for the various interaction potential graphs make the code very hard to maintain, and there is inappropriate coupling between the various levels of the hierarchy. Much of this is on me, since I allowed it to pass code review, but I shouldn't have. I'm generally the one who pays the price by having to navigate these oddities, so I guess that's karma in action.
Honestly, I don't know if it will ever become a high enough priority to address this, but it will have to be done if we ever want to reuse these graphs in another simulation. I'll try to make improvements whenever I have to touch the code, as I just did, but what it really needs is a thoughtful rewrite.
I guess I'm logging this mostly as a signpost to any future would be users of the code for the interaction potential graphs: Here be dragons.
The text was updated successfully, but these errors were encountered:
I've noticed this before, but it became painfully apparent while working on #352. The inheritance hierarchy for the various interaction potential graphs make the code very hard to maintain, and there is inappropriate coupling between the various levels of the hierarchy. Much of this is on me, since I allowed it to pass code review, but I shouldn't have. I'm generally the one who pays the price by having to navigate these oddities, so I guess that's karma in action.
Honestly, I don't know if it will ever become a high enough priority to address this, but it will have to be done if we ever want to reuse these graphs in another simulation. I'll try to make improvements whenever I have to touch the code, as I just did, but what it really needs is a thoughtful rewrite.
I guess I'm logging this mostly as a signpost to any future would be users of the code for the interaction potential graphs: Here be dragons.
The text was updated successfully, but these errors were encountered: