Thermometer resets tilted on states screen.

[JRomero0613]

Device:
Mac OS X El Capitan v. 10.11.6
Browser:
Chrome v. 68.0.3440.106
Problem description:
Noticed while testing phetsims/qa#164 on the states screen heat an atom or molecule to the point where the lid flies off (I used Argon) and choose a different atom or molecule to reset the lid. The thermometer should now be reset to its original position but it will be cocked to the side. The thermometer and sim still function as expected, this is more of a design note. I have attached a screenshot of how the thermometer looks in this tilted position.

[KatieWoe]

Just tested this on the published sim and it does occur there as well.

[jbphet]

Interesting test case, I've never done that. I've added code to reset the rotational angle of the thermometer when the lid is returned after the container explodes.

[JRomero0613]

I've just tested this issue in master on macOS Sierra v. 10.12.6 on Chrome v. 68.0.3440.106, Firefox v. 61.0.2, and Safari v. 10.1.2.12603.3.8 and it has been fixed. I move to close this issue, with a check to make sure it has been fixed in the next round of testing.

[phet-steele]

I've caused this in 1.1.0-rc.1. The rotation is correct, but the position is not.

I'm not sure how close to the original steps I was (since I think they may have been missing some details), nor am I sure that what I did is important, but here they are:

1. Heat Argon.
2. JUST as the lid blows, BEFORE the thermometer leaves the top of the screen, click Neon.

Seen on Win 10 Chrome. For phetsims/qa/issues/185.

Troubleshooting Information

[KatieWoe]

Using @JRomero0613 method it does seem fixed (this is the same as @phet-steele method but clicking Neon later, after the lid leaves.)
@phet-steele that's a good catch. One addition to step 2. It looks like you need to click Neon before the lid leaves the screen, not necessarily before the thermometer, leaving a bit more wiggle room. Most easily done if you have a multitouch screen.

[KatieWoe]

Hitting the orange reset button does not move the thermometer back.

[jbphet]

I certainly appreciate how thoroughly you folks test these things! It turns out that if the thermometer node is moved back into place when rotated (due to its movement after an explosion), and then de-rotated to a rotation angle of 0, its position is off because the rotation operation uses the origin of the node rather than its center. I fixed this be changing the order of operations to do the de-rotation first, then set the position.

[jbphet]

Assigning to QA to updated based on the results of the 1.1.0-rc.2 testing.

[KatieWoe]

Confirm 1.1.0-rc.2

[jbphet]

Deployed in v1.1.0, closing.