Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test particle behavior after changes to thermostats #164

Closed
jbphet opened this issue Aug 8, 2018 · 4 comments
Closed

Test particle behavior after changes to thermostats #164

jbphet opened this issue Aug 8, 2018 · 4 comments
Assignees
Labels
dev:model QA:dev-test Dev test before an RC

Comments

@jbphet
Copy link
Contributor

jbphet commented Aug 8, 2018

In the course of addressing phetsims/states-of-matter-basics#15 and some of the concerns described in phetsims/states-of-matter#214 I ended up making some changes to both the isokinetic thermostat and the Andersen thermostat code. It would be good to verify that the behavior of the particles in the container didn't change radically as a result. The intent of the changes was to minimize the amount of drift to the right or left when the particles are in solid form with no heat or cooling applied and when the particles start in solid form and are heated. Please test the behavior of the particles in the container on the dev version linked below and log any behavior that is significantly different from the current published version (v1.0.3) and log any significant and potentially problematic differences.

https://phet-dev.colorado.edu/html/states-of-matter/1.1.0-dev.3/phet/states-of-matter_en_phet.html

@KatieWoe
Copy link
Contributor

KatieWoe commented Aug 8, 2018

Assigning @ariel-phet for priority.

@ariel-phet ariel-phet removed their assignment Aug 9, 2018
@ariel-phet
Copy link
Contributor

@KatieWoe hoping to get SOM re-released soon, so marking high priority

@KatieWoe
Copy link
Contributor

QA is finished

@jbphet
Copy link
Contributor Author

jbphet commented Aug 20, 2018

Thanks for the testing, I'll start addressing the issues that resulted. Closing.

@jbphet jbphet closed this as completed Aug 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev:model QA:dev-test Dev test before an RC
Projects
None yet
Development

No branches or pull requests

3 participants