Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Solid" drifts to the left on States Screen #15

Closed
oliver-phet opened this issue Dec 22, 2016 · 6 comments
Closed

"Solid" drifts to the left on States Screen #15

oliver-phet opened this issue Dec 22, 2016 · 6 comments

Comments

@oliver-phet
Copy link

oliver-phet commented Dec 22, 2016

Start the sim and open the States screen. The atoms gradually shift to the left. This behavior isn't in the full version.

screen shot 2016-12-22 at 2 59 12 pm

Looks like it occurs on Phase Changes as well.

@oliver-phet
Copy link
Author

Whoops - I take it back. The full version does this too. Intentional?

@oliver-phet
Copy link
Author

Looks like this was present in Java too: https://phet.unfuddle.com/a#/projects/9404/tickets/by_number/2057

@jbphet
Copy link
Contributor

jbphet commented Aug 1, 2018

I did two things to fix this:

  • added a step to the code the forms the solid that averages the velocity to zero
  • added a slight concavity to the bottom of the container to push the particles back towards the center if they drift

The latter was done as part of a larger commit to address drift, see phetsims/states-of-matter@4a526e2.

So far, this seems to be working pretty well.

@jbphet
Copy link
Contributor

jbphet commented Aug 1, 2018

I'm going to have to back out the concave bottom. During testing I found that this can cause side-to-side oscillations of the solid when it gets to absolute zero.

@KatieWoe
Copy link
Contributor

KatieWoe commented Sep 12, 2018

Looks good. Closing 1.1.0-rc.1

@KatieWoe
Copy link
Contributor

This also looks good in 1.1.0-rc.2 Of basics

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants