Run code inspection, see: phetsims/mean-share-and-balance#258

phetsims · Jun 7, 2024 · b498820 · b498820
1 parent 8e4a100
commit b498820
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 3 deletions.
diff --git a/js/model/SoccerBall.ts b/js/model/SoccerBall.ts
@@ -33,7 +33,7 @@ let count = 0;
 export default class SoccerBall extends PhetioObject {
 
   /**
-   * Continuous value for the drag listener. When dragging, the object snaps to each tickmark. This is an implementation
+   * Continuous value for the drag listener. When dragging, the object snaps to each tick mark. This is an implementation
    * detail for the drag listener that is only used for deltas, and the absolute value does not matter.
    * Therefore, it should not be reset (because resetting it would take the model through an incorrect transient state).
    *

diff --git a/js/model/SoccerBallValueProperty.ts b/js/model/SoccerBallValueProperty.ts
@@ -30,6 +30,7 @@ export default class SoccerBallValueProperty extends Property<number | null> {
 
   /**
    * @param value - The soccer ball's location on the number line. If the soccer ball has not yet landed, 'value' is null.
+   * @param providedOptions
    */
   public constructor( value: number | null, providedOptions?: SoccerBallValuePropertyOptions ) {
 

diff --git a/js/model/SoccerSceneModel.ts b/js/model/SoccerSceneModel.ts
@@ -580,7 +580,7 @@ export default class SoccerSceneModel<T extends SoccerBall = SoccerBall> extends
 
       // Even number of values, average the two middle-most values
       const mid1Index = ( sortedObjects.length - 2 ) / 2;
-      const mid2Index = ( sortedObjects.length - 0 ) / 2;
+      const mid2Index = ( sortedObjects.length ) / 2;
       return [ sortedObjects[ mid1Index ], sortedObjects[ mid2Index ] ];
     }
     else {

diff --git a/js/view/SoccerSceneView.ts b/js/view/SoccerSceneView.ts
@@ -104,7 +104,7 @@ export default class SoccerSceneView<SceneModel extends SoccerSceneModel = Socce
 
       backLayerSoccerBallLayer.addChild( soccerBallNode );
 
-      // While flying, it should be in front in z-order, to be in front of the accordion box
+      // While flying, it should be at the front in z-order, to be in front of the accordion box
       soccerBall.soccerBallPhaseProperty.lazyLink( ( soccerBallPhase, oldSoccerBallPhase ) => {
 
         //when the ball is kicked
-Original file line number
+Diff line change
@@ Expand Up @@
       /**
        * @param value - The soccer ball's location on the number line. If the soccer ball has not yet landed, 'value' is null.
+       * @param providedOptions
        */
       public constructor( value: number | null, providedOptions?: SoccerBallValuePropertyOptions ) {
@@ Expand Down @@