Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cross-orientation sizable support #1453

Closed
jonathanolson opened this issue Sep 20, 2022 · 3 comments
Closed

Cross-orientation sizable support #1453

jonathanolson opened this issue Sep 20, 2022 · 3 comments
Assignees
@marlitas

Comments

@jonathanolson
Copy link
Contributor

Adding support to properly adjust/forward preferred/minimum sizes to the OTHER orientation if there is a 90/-90 degree angle. We've sometimes rotated components by that (Math.PI/2), and in that case the localPreferredWidth should be connected to the preferredHeight (and vice versa, and also for minimums).
@jonathanolson jonathanolson self-assigned this Sep 20, 2022
jonathanolson added a commit to phetsims/area-model-common that referenced this issue Sep 20, 2022
@jonathanolson
Sizable cross-orientation support, see phetsims/scenery#1453, and rem…
d4ccba5 
…oving a LayoutBox instance for phetsims/scenery#1420. Matrix3 rotations improved to have true zeros for Math.PI/2 rotations
jonathanolson added a commit to phetsims/blackbody-spectrum that referenced this issue Sep 20, 2022
@jonathanolson
Sizable cross-orientation support, see phetsims/scenery#1453, and rem…
e683d53 
…oving a LayoutBox instance for phetsims/scenery#1420. Matrix3 rotations improved to have true zeros for Math.PI/2 rotations
jonathanolson added a commit to phetsims/collision-lab that referenced this issue Sep 20, 2022
@jonathanolson
Sizable cross-orientation support, see phetsims/scenery#1453, and rem…
d3a9596 
…oving a LayoutBox instance for phetsims/scenery#1420. Matrix3 rotations improved to have true zeros for Math.PI/2 rotations
jonathanolson added a commit to phetsims/dot that referenced this issue Sep 20, 2022
@jonathanolson
Sizable cross-orientation support, see phetsims/scenery#1453, and rem…
178a608 
…oving a LayoutBox instance for phetsims/scenery#1420. Matrix3 rotations improved to have true zeros for Math.PI/2 rotations
jonathanolson added a commit to phetsims/mobius that referenced this issue Sep 20, 2022
@jonathanolson
Sizable cross-orientation support, see phetsims/scenery#1453, and rem…
8cbb936 
…oving a LayoutBox instance for phetsims/scenery#1420. Matrix3 rotations improved to have true zeros for Math.PI/2 rotations
jonathanolson added a commit to phetsims/phet-core that referenced this issue Sep 20, 2022
@jonathanolson
Sizable cross-orientation support, see phetsims/scenery#1453, and rem…
17983a3 
…oving a LayoutBox instance for phetsims/scenery#1420. Matrix3 rotations improved to have true zeros for Math.PI/2 rotations
jonathanolson added a commit that referenced this issue Sep 20, 2022
@jonathanolson
Sizable cross-orientation support, see #1453, and removing a LayoutBo…
01696ff 
…x instance for #1420. Matrix3 rotations improved to have true zeros for Math.PI/2 rotations
@jonathanolson
Copy link
Contributor Author

@marlitas, would you be able to review (possibly together with me) the above changes?

Notably, before this, some buttons were broken with 90-degree rotated content (build-a-nucleus is one example).

@marlitas
Copy link
Contributor

I looked through the code changes and everything looks good from my perspective.

The only question I have regards changes in Sizable. I think I may be confused as to how matrix axis alignment defined in Matrix3 connects to a rotation matrix. I would love to chat more about this to clarify my understanding.

@marlitas
Copy link
Contributor

@jonathanolson and I talked through this and I have no more questions. Closing as completed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marlitas marlitas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jonathanolson @marlitas