Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace LayoutBox with FlowBox/HBox/VBox #1420

Closed
27 tasks done
pixelzoom opened this issue May 31, 2022 · 6 comments
Closed
27 tasks done

Replace LayoutBox with FlowBox/HBox/VBox #1420

pixelzoom opened this issue May 31, 2022 · 6 comments
Assignees
@jonathanolson
Labels
dev:chip-away priority:2-high

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented May 31, 2022 •
edited by jonathanolson
Loading

LayoutBox was deprecated for phetsims/sun#48, and FlowBox/HBox/VBox should now be used. Use HBox or VBox is your orientation is fixed. Use FlowBox if your orientation is computed.

Common-code uses should be converted eagerly, sim uses can be converted as needed.

common code:

sims:
@pixelzoom pixelzoom changed the title Replace LayoutBox with FlowBox Replace LayoutBox with FlowBox/HBox/VBox May 31, 2022
pixelzoom added a commit to phetsims/beers-law-lab that referenced this issue May 31, 2022
@pixelzoom
replace LayoutBox with VBox or HBox, phetsims/scenery#1420
62cd25a
pixelzoom added a commit to phetsims/ph-scale that referenced this issue May 31, 2022
@pixelzoom
replace LayoutBox with VBox or HBox, phetsims/scenery#1420
f351d15
pixelzoom added a commit to phetsims/chains that referenced this issue May 31, 2022
@pixelzoom
replace LayoutBox with VBox or HBox, phetsims/scenery#1420
ce4a1be
pixelzoom referenced this issue in phetsims/scenery-phet May 31, 2022
@pixelzoom
deprecate LayoutBox, phetsims/scenery#1418
37e8a1f
pixelzoom referenced this issue in phetsims/scenery-phet May 31, 2022
@pixelzoom
deprecate LayoutBox, phetsims/scenery#1418
5d10936
pixelzoom referenced this issue in phetsims/energy-forms-and-changes May 31, 2022
@pixelzoom
deprecate LayoutBox, phetsims/scenery#1418
d649ad2
pixelzoom referenced this issue in phetsims/coulombs-law May 31, 2022
@pixelzoom
deprecate LayoutBox, phetsims/scenery#1418
4fb7d26
pixelzoom referenced this issue in phetsims/charges-and-fields May 31, 2022
@pixelzoom
deprecate LayoutBox, phetsims/scenery#1418
931472f
pixelzoom referenced this issue in phetsims/equality-explorer May 31, 2022
@pixelzoom
deprecate LayoutBox, phetsims/scenery#1418
ad49768
pixelzoom referenced this issue in phetsims/fourier-making-waves May 31, 2022
@pixelzoom
deprecate LayoutBox, phetsims/scenery#1418
8258373
pixelzoom referenced this issue in phetsims/fourier-making-waves May 31, 2022
@pixelzoom
deprecate LayoutBox, phetsims/scenery#1418
1f85021
pixelzoom referenced this issue in phetsims/wilder May 31, 2022
@pixelzoom
deprecate LayoutBox, phetsims/scenery#1418
abe2db6
pixelzoom referenced this issue in phetsims/reactants-products-and-leftovers May 31, 2022
@pixelzoom
deprecate LayoutBox, phetsims/scenery#1418
1b34309
pixelzoom referenced this issue in phetsims/vector-addition May 31, 2022
@pixelzoom
deprecate LayoutBox, phetsims/scenery#1418
b955933
pixelzoom referenced this issue in phetsims/molecule-polarity May 31, 2022
@pixelzoom
deprecate LayoutBox, phetsims/scenery#1418
fb08704
pixelzoom referenced this issue in phetsims/graphing-lines May 31, 2022
@pixelzoom
deprecate LayoutBox, phetsims/scenery#1418
3b22211
pixelzoom added a commit to phetsims/scenery-phet that referenced this issue May 31, 2022
@pixelzoom
fix optionize call in ZoomButtonGroup, phetsims/scenery#1420
5d407c6
pixelzoom added a commit to phetsims/scenery-phet that referenced this issue May 31, 2022
@pixelzoom
replace LayoutBox with VBox or HBox, phetsims/scenery#1420
a9193ea
pixelzoom added a commit to phetsims/sun that referenced this issue May 31, 2022
@pixelzoom
replace LayoutBox with VBox or HBox, phetsims/scenery#1420
a4f444f
pixelzoom added a commit to phetsims/sun that referenced this issue May 31, 2022
@pixelzoom
replace LayoutBox with VBox or HBox, phetsims/scenery#1420
9ba13e8
pixelzoom added a commit to phetsims/joist that referenced this issue May 31, 2022
@pixelzoom
replace LayoutBox with VBox or HBox, phetsims/scenery#1420
9340783
jbphet added a commit to phetsims/number-line-distance that referenced this issue Jun 3, 2022
@jbphet
adjusted layout to work better with new FlowLayout, see #73 and phets…
e52af77 
…ims/scenery#1420
@jbphet
Copy link
Contributor

jbphet commented Jun 3, 2022

@jbphet be aware that converting number-line-distance to FlowBox is going to be trouble. You're using a negative distance between children, and that's not supported by FlowBox.

This has been handled, see phetsims/number-line-distance#73 for details.

@jbphet jbphet removed their assignment Jun 3, 2022
@samreid samreid removed their assignment Jun 14, 2022
samreid added a commit to phetsims/bamboo that referenced this issue Jun 14, 2022
@samreid
Use FlowBox instead of LayoutBox, see phetsims/scenery#1420
eb89ff6
jonathanolson added a commit to phetsims/area-model-common that referenced this issue Sep 20, 2022
@jonathanolson
Sizable cross-orientation support, see phetsims/scenery#1453, and rem…
d4ccba5 
…oving a LayoutBox instance for phetsims/scenery#1420. Matrix3 rotations improved to have true zeros for Math.PI/2 rotations
jonathanolson added a commit to phetsims/blackbody-spectrum that referenced this issue Sep 20, 2022
@jonathanolson
Sizable cross-orientation support, see phetsims/scenery#1453, and rem…
e683d53 
…oving a LayoutBox instance for phetsims/scenery#1420. Matrix3 rotations improved to have true zeros for Math.PI/2 rotations
jonathanolson added a commit to phetsims/collision-lab that referenced this issue Sep 20, 2022
@jonathanolson
Sizable cross-orientation support, see phetsims/scenery#1453, and rem…
d3a9596 
…oving a LayoutBox instance for phetsims/scenery#1420. Matrix3 rotations improved to have true zeros for Math.PI/2 rotations
jonathanolson added a commit to phetsims/dot that referenced this issue Sep 20, 2022
@jonathanolson
Sizable cross-orientation support, see phetsims/scenery#1453, and rem…
178a608 
…oving a LayoutBox instance for phetsims/scenery#1420. Matrix3 rotations improved to have true zeros for Math.PI/2 rotations
jonathanolson added a commit to phetsims/mobius that referenced this issue Sep 20, 2022
@jonathanolson
Sizable cross-orientation support, see phetsims/scenery#1453, and rem…
8cbb936 
…oving a LayoutBox instance for phetsims/scenery#1420. Matrix3 rotations improved to have true zeros for Math.PI/2 rotations
jonathanolson added a commit to phetsims/phet-core that referenced this issue Sep 20, 2022
@jonathanolson
Sizable cross-orientation support, see phetsims/scenery#1453, and rem…
17983a3 
…oving a LayoutBox instance for phetsims/scenery#1420. Matrix3 rotations improved to have true zeros for Math.PI/2 rotations
jonathanolson added a commit that referenced this issue Sep 20, 2022
@jonathanolson
Sizable cross-orientation support, see #1453, and removing a LayoutBo…
01696ff 
…x instance for #1420. Matrix3 rotations improved to have true zeros for Math.PI/2 rotations
jonathanolson added a commit to phetsims/area-model-common that referenced this issue Sep 20, 2022
@jonathanolson
LayoutBox => FlowBox, see phetsims/scenery#1420
8578003
jonathanolson added a commit to phetsims/bamboo that referenced this issue Sep 20, 2022
@jonathanolson
Removing LayoutBox, see phetsims/scenery#1420
39d40d9
jonathanolson added a commit to phetsims/collision-lab that referenced this issue Sep 20, 2022
@jonathanolson
Removing LayoutBox, see phetsims/scenery#1420
ab27a45
jonathanolson added a commit to phetsims/fourier-making-waves that referenced this issue Sep 20, 2022
@jonathanolson
Removing LayoutBox, see phetsims/scenery#1420
f0badc0
jonathanolson added a commit to phetsims/joist that referenced this issue Sep 20, 2022
@jonathanolson
Removing LayoutBox, see phetsims/scenery#1420
8d63af7
jonathanolson added a commit to phetsims/phet-core that referenced this issue Sep 20, 2022
@jonathanolson
Removing LayoutBox, see phetsims/scenery#1420
afcc7b5
jonathanolson added a commit to phetsims/phet-info that referenced this issue Sep 20, 2022
@jonathanolson
Removing LayoutBox, see phetsims/scenery#1420
b155733
jonathanolson added a commit that referenced this issue Sep 20, 2022
@jonathanolson
Removing LayoutBox, see #1420
46db815
jonathanolson added a commit to phetsims/vector-addition that referenced this issue Sep 20, 2022
@jonathanolson
Removing LayoutBox, see phetsims/scenery#1420
90e2b44
@jonathanolson
Copy link
Contributor

Removed all LayoutBox cases, closing!

pixelzoom added a commit to phetsims/fourier-making-waves that referenced this issue Sep 20, 2022
@pixelzoom
fix assertion message, phetsims/scenery#1420
bfd16f6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonathanolson jonathanolson

Labels
dev:chip-away priority:2-high
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@jonathanolson @samreid @pixelzoom @jbphet @chrisklus @jessegreenberg @zepumph