-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some sims fail to start in the Android app #674
Comments
In discussion with @jonathanolson, he said it could be a number of things. One potential problem is faulty metrics. We could probably see the more precise problem if we could see a debugger. Alternatively, we could set up a test harness that uses little or no phet-specific code to try to track this down. I volunteered to take a look, but would probably need to coordinate with @KatieWoe . |
In phetsims/gravity-and-orbits#382 (comment), @mattpen said:
Having a debugger set up seems like the most efficient way to diagnose and address this font problem. |
That looks like the same problem as phetsims/phet-android-app#155, I should investigate and make sure the RC has the patch. @jessegreenberg can you please assist? Does gravity-and-orbits 1.4 have the SHAs to correct phetsims/phet-android-app#155 ? |
The URL in #674 (comment) actually points to GAO 1.4 rc.1, and I would still expect to still see the issue there. I verified that gravity-and-orbits 1.4 was included by the automated MR process with phetsims/gravity-and-orbits@3c59924 and I see scenery branch https://github.com/phetsims/scenery/tree/gravity-and-orbits-1.4. So I would expect this to be fixed in gravity-and-orbits rc.2 when that is built with the updated scenery SHA. |
Sorry, mistyped |
@KatieWoe - I cannot tell if this is really still an issue. Are there other sims that fail in the Android app right now? |
There weren't in published when I was testing the app for phetsims/qa#612. This came about from testing a few rcs before they went out and seeing the issue. I don't know of any published that have the issue, but I can, of course, check again to make sure. |
@samreid let me know if you want me to do a quick search through published sims to see if this issue comes up elsewhere. |
@KatieWoe did you mention another RC that failed to load in the app--maybe Waves Intro? |
Yes. This was noted in phetsims/gravity-and-orbits#382 (comment) |
In phetsims/gravity-and-orbits#382 (comment) we said:
| 1.2.0-dev.17/ | 2020-10-30 11:47 | - | This is the same time frame that |
This version uses the suspicious fonts on Android: |
This version uses 'monospace' on Android, which should be very safe: @KatieWoe can you please test 1.5.0-dev.3 and dev.4 in the app? This will help us determine if the font was a red herring. If dev.3 crashes but dev.4 is OK, can you please test in the app with the debugger to see if there is additional information? |
Waves Intro 1.1 rc.4 (mentioned in phetsims/gravity-and-orbits#382 (comment)) will also fail to load because of the |
Both dev.3 and dve.4 seem to work on the device. Not sure why. |
OK I think the font was a red herring, my mistake! I think https://github.com/phetsims/phet-android-app/issues/155 was the root cause all along. I recommend closing this issue, and in phetsims/gravity-and-orbits#382 (comment) I'll revert the font change for Android. |
From phetsims/gravity-and-orbits#382. We determined that specifying font
'"Trebuchet MS", "Lucida Grande", monospace'
crashes Gravity and Orbits on startup (in the Android app on @KatieWoe test device, but still runs fine in Android Chrome and in the app on @mattpen test device), but'monospace'
runs fine in both. Also a note that@jonathanolson can you help us investigate?
Also, as part of this issue, we should see what sims have been published with the troublesome fonts to see if they require a maintenance release. I can help with that step once we isolate and resolve the problem.
The text was updated successfully, but these errors were encountered: