Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RC Spot Check Test: waves-intro/1.1.0-rc.4 #603

Closed
3 tasks done
samreid opened this issue Jan 30, 2021 · 8 comments
Closed
3 tasks done

RC Spot Check Test: waves-intro/1.1.0-rc.4 #603

samreid opened this issue Jan 30, 2021 · 8 comments
Assignees
Labels
QA:published When a completed test leads to publication, it is marked as published, so we can see them in a list QA:rc-spot-check QA:rc-test

Comments

@samreid
Copy link
Member

samreid commented Jan 30, 2021

I haven't made a spot test issue recently, so I'll endeavor to be succinct. This issue is the same as #580 except we have addressed the following issues which require spot testing:

I cherry picked the fixes for

I published https://phet-dev.colorado.edu/html/waves-intro/1.1.0-rc.4/phet/waves-intro_all_phet.html for testing and we can move forward with it unless we determine phetsims/wave-interference#512 is blocking.

@KatieWoe should I use the full template for this? Do you need any additional information?

@KatieWoe
Copy link
Contributor

KatieWoe commented Feb 1, 2021

@samreid this should be enough.

@KatieWoe KatieWoe changed the title RC Test: waves-intro/1.1.0-rc.4 RC Spot Check Test: waves-intro/1.1.0-rc.4 Feb 1, 2021
@KatieWoe
Copy link
Contributor

KatieWoe commented Feb 1, 2021

  • Win 10 Chrome (Time = 2.5hr)
  • Win 10 Firefox (Time = 0.5hr)
  • Mac 11 Safari (Time = )
  • iPadOS Safari (Time = 1.0 hr )
  • ChromeOS (Time = )

@jessegreenberg
Copy link
Contributor

jessegreenberg commented Feb 12, 2021

@samreid @KatieWoe wavesi-intro 1.1 scenery SHAs received a patch for phetsims/phet-android-app#155.

If possible, you may wish to verify this sim works well in the PhET Android app as part of this test. EDIT: Fix not in this build, should be in NEXT test.

@liammulh
Copy link
Member

phetsims/wave-interference#513 looks to be fixed. phetsims/wave-interference#516 looks to be fixed. phetsims/wave-interference#510 looks to be fixed. All on macOS 11.2 + Safari 14.0.3.

@brooklynlash
Copy link

Issues #513, #516, #510 all seem to be fixed on Win10 Chrome and Firefox

@kathy-phet
Copy link

@KatieWoe - Can you review to see if this spot-check has had enough testing to be called done. Looks like issues have been checked on a few platforms. Thanks!

@KatieWoe
Copy link
Contributor

QA is done

@samreid
Copy link
Member Author

samreid commented Mar 22, 2021

It seems like all issues were resolved and no new issues discovered during RC.4. Therefore, I'll publish the simulation, tracking that work in phetsims/wave-interference#509

@samreid samreid closed this as completed Mar 22, 2021
@kathy-phet kathy-phet added the QA:published When a completed test leads to publication, it is marked as published, so we can see them in a list label Apr 1, 2021
@KatieWoe KatieWoe moved this to Done in QA Pipeline Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA:published When a completed test leads to publication, it is marked as published, so we can see them in a list QA:rc-spot-check QA:rc-test
Projects
Status: Done
Development

No branches or pull requests

6 participants