-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RC Spot Check Test: waves-intro/1.1.0-rc.4 #603
Comments
@samreid this should be enough. |
|
phetsims/wave-interference#513 looks to be fixed. phetsims/wave-interference#516 looks to be fixed. phetsims/wave-interference#510 looks to be fixed. All on macOS 11.2 + Safari 14.0.3. |
@KatieWoe - Can you review to see if this spot-check has had enough testing to be called done. Looks like issues have been checked on a few platforms. Thanks! |
QA is done |
It seems like all issues were resolved and no new issues discovered during RC.4. Therefore, I'll publish the simulation, tracking that work in phetsims/wave-interference#509 |
I haven't made a spot test issue recently, so I'll endeavor to be succinct. This issue is the same as #580 except we have addressed the following issues which require spot testing:
I cherry picked the fixes for
I published https://phet-dev.colorado.edu/html/waves-intro/1.1.0-rc.4/phet/waves-intro_all_phet.html for testing and we can move forward with it unless we determine phetsims/wave-interference#512 is blocking.
@KatieWoe should I use the full template for this? Do you need any additional information?
The text was updated successfully, but these errors were encountered: