Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

You can pause the continuous speaker membrane at any position, and when you resume playing, it may not trigger a sound depending on the membrane position. #512

Open
samreid opened this issue Jan 11, 2021 · 4 comments

Comments

@samreid
Copy link
Member

samreid commented Jan 11, 2021

Discovered in #510, you can pause the continuous speaker membrane at any position, and when you resume playing, it may not trigger a sound depending on the membrane position.

@samreid samreid changed the title you can pause the continuous speaker membrane at any position, and when you resume playing, it may not trigger a sound depending on the membrane position. You can pause the continuous speaker membrane at any position, and when you resume playing, it may not trigger a sound depending on the membrane position. Jan 11, 2021
@samreid
Copy link
Member Author

samreid commented Jan 12, 2021

In #510 (comment) @KatieWoe said:

I think I saw what @samreid mentioned in #510 (comment). If you stop a wave at as the sound starts, it can mess up the sound when it starts at a new frequency. I have had the wrong frequency start then fix itself, or the sound take a fair amount of time to start.
https://drive.google.com/file/d/1N7DIgNoMb2OKR13YHVgrcMhqMSXopjN4/view?usp=sharing

@KatieWoe
Copy link
Contributor

I just noticed that this seems to happen in phetsims/qa#580, so it is unlikely to be related to the fix for #510

@samreid
Copy link
Member Author

samreid commented Jan 29, 2021

This does not feel blocking to me, @arouinfar what do you recommend?

@arouinfar
Copy link
Contributor

Nice find! @samreid I would agree that this is not blocking. At worst, the speaker membrane sound is missing/off for one round which doesn't seem particularly serious to me.

@arouinfar arouinfar assigned samreid and unassigned arouinfar Feb 1, 2021
@samreid samreid removed their assignment Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants