better dispose (bug fix), phetsims/density-buoyancy-common#364

Signed-off-by: Michael Kauzmann <[email protected]>
phetsims · Aug 29, 2024 · 10b5c11 · 10b5c11
1 parent 725e706
commit 10b5c11
Showing 1 changed file with 3 additions and 10 deletions.
diff --git a/js/accessibility/GrabDragInteraction.ts b/js/accessibility/GrabDragInteraction.ts
@@ -663,15 +663,8 @@ export default class GrabDragInteraction extends EnabledComponent {
         }
       }
 
-      if ( voicingNode.interactiveHighlightLayerable ) {
-        const highlightParent = this.grabInteractiveHighlight.parent!;
-        assert && assert( highlightParent, 'how can we have interactiveHighlightLayerable with a ' +
-                                           'node that is not in the scene graph?' );
-
-        if ( highlightParent.hasChild( this.dragInteractiveHighlight ) ) {
-          highlightParent.removeChild( this.dragInteractiveHighlight );
-        }
-      }
+      // to support cases of interactiveHighlightLayerable
+      this.dragInteractiveHighlight.detach();
 
       releasedUtterance.dispose();
       this.voicingFocusUtterance.dispose();
@@ -680,7 +673,7 @@ export default class GrabDragInteraction extends EnabledComponent {
       this.ownsGrabFocusHighlight && this.grabFocusHighlight.dispose();
       this.ownsGrabInteractiveHighlight && this.grabInteractiveHighlight.dispose();
       this.grabCueNode.dispose();
-      this.dragCueNode && ( this.dragFocusHighlight.focusHighlight as HighlightPath ).removeChild( this.dragCueNode );
+      this.dragCueNode && this.dragCueNode.detach();
     };
   }