Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add drag cues to the GrabDragInteraction #364

Closed
zepumph opened this issue Aug 26, 2024 · 5 comments
Closed

Add drag cues to the GrabDragInteraction #364

zepumph opened this issue Aug 26, 2024 · 5 comments
Assignees
@DianaTavares
Labels
dev:alt-input status:ready-for-review

Comments

@zepumph
Copy link
Member

zepumph commented Aug 26, 2024

From #354 (comment)

@DianaTavares let's discuss the design for this a bit more. I'm not sure if we have defaults here since they normally surround the sim object.
@DianaTavares
Copy link

Tomorrow after stand-up, I am available!

This was referenced Aug 27, 2024
Closed
Closed
@zepumph
Copy link
Member Author

zepumph commented Aug 27, 2024

We want to try to duplicate the WASD + arrow cue from BASE. It seems nice!

image

@zepumph zepumph removed their assignment Aug 27, 2024
@zepumph zepumph assigned zepumph and unassigned DianaTavares Aug 27, 2024
zepumph added a commit to phetsims/chipper that referenced this issue Aug 29, 2024
@zepumph
convert BalloonInteractionCueNode to typescript, phetsims/density-buo…
a3f46af 
…yancy-common#364

Signed-off-by: Michael Kauzmann <[email protected]>
zepumph added a commit to phetsims/balloons-and-static-electricity that referenced this issue Aug 29, 2024
@zepumph
convert BalloonInteractionCueNode to typescript, phetsims/density-buo…
e68205a 
…yancy-common#364

Signed-off-by: Michael Kauzmann <[email protected]>
zepumph added a commit to phetsims/balloons-and-static-electricity that referenced this issue Aug 29, 2024
@zepumph
factor out WASDCueNode, phetsims/density-buoyancy-common#364
31a5174 
Signed-off-by: Michael Kauzmann <[email protected]>
@zepumph zepumph mentioned this issue Aug 29, 2024
Closed
zepumph added a commit to phetsims/balloons-and-static-electricity that referenced this issue Aug 29, 2024
@zepumph
use scenery-phet's cue node, phetsims/density-buoyancy-common#364
e75caa4 
Signed-off-by: Michael Kauzmann <[email protected]>
zepumph added a commit that referenced this issue Aug 29, 2024
@zepumph
use BASE drag cue in DBC, #364
9d75039 
Signed-off-by: Michael Kauzmann <[email protected]>
zepumph added a commit to phetsims/scenery-phet that referenced this issue Aug 29, 2024
@zepumph
convert BalloonInteractionCueNode to typescript, phetsims/density-buo…
364285f 
…yancy-common#364

Signed-off-by: Michael Kauzmann <[email protected]>
zepumph added a commit to phetsims/balloons-and-static-electricity that referenced this issue Aug 29, 2024
@zepumph
rename to WASDCueNode, phetsims/density-buoyancy-common#364
1bfc228 
Signed-off-by: Michael Kauzmann <[email protected]>
zepumph added a commit to phetsims/scenery-phet that referenced this issue Aug 29, 2024
@zepumph
factor out WASDCueNode, phetsims/density-buoyancy-common#364
55688b3 
Signed-off-by: Michael Kauzmann <[email protected]>
zepumph added a commit that referenced this issue Aug 29, 2024
@zepumph
turn drag cue off upon first successful keyboard drag, #364
d2dc49e 
Signed-off-by: Michael Kauzmann <[email protected]>
zepumph added a commit to phetsims/scenery-phet that referenced this issue Aug 29, 2024
@zepumph
move to accessibility/nodes [BROKEN], phetsims/density-buoyancy-commo…
41984c1 
…n#364

Signed-off-by: Michael Kauzmann <[email protected]>
zepumph added a commit to phetsims/scenery-phet that referenced this issue Aug 29, 2024
@zepumph
use scenery-phet's cue node, phetsims/density-buoyancy-common#364
85e0980 
Signed-off-by: Michael Kauzmann <[email protected]>
zepumph added a commit to phetsims/scenery-phet that referenced this issue Aug 29, 2024
@zepumph
rename to WASDCueNode, phetsims/density-buoyancy-common#364
725e706 
Signed-off-by: Michael Kauzmann <[email protected]>
zepumph added a commit to phetsims/scenery-phet that referenced this issue Aug 29, 2024
@zepumph
better dispose (bug fix), phetsims/density-buoyancy-common#364
10b5c11 
Signed-off-by: Michael Kauzmann <[email protected]>
zepumph added a commit to phetsims/scenery-phet that referenced this issue Aug 29, 2024
@zepumph
turn drag cue off upon first successful keyboard drag, phetsims/densi…
b114158 
…ty-buoyancy-common#364

Signed-off-by: Michael Kauzmann <[email protected]>
@zepumph
Copy link
Member Author

zepumph commented Aug 29, 2024

Alright. I believe this is ready for design review.

Let's focus on the look of the cue here, and talk about the hiding logic over in #368.

image

@zepumph zepumph assigned DianaTavares and unassigned zepumph Aug 29, 2024
@samreid
Copy link
Member

samreid commented Aug 30, 2024

There appear to be memory leaks in this feature, I proposed a partial remedy in #168

@zepumph
Copy link
Member Author

zepumph commented Aug 30, 2024

In design meeting we love this. No notes. Closing

@zepumph zepumph closed this as completed Aug 30, 2024
zepumph referenced this issue Aug 30, 2024
@zepumph
More memory leaks!, #168
b52b690 
Signed-off-by: Michael Kauzmann <[email protected]>
zepumph referenced this issue in phetsims/scenery-phet Aug 30, 2024
@zepumph
More memory leaks!, phetsims/density-buoyancy-common#168
e2f4bb9 
Signed-off-by: Michael Kauzmann <[email protected]>
samreid pushed a commit to phetsims/perennial that referenced this issue Oct 21, 2024
@zepumph @samreid
convert BalloonInteractionCueNode to typescript, phetsims/density-buo…
b85a9ff 
…yancy-common#364

Signed-off-by: Michael Kauzmann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DianaTavares DianaTavares

Labels
dev:alt-input status:ready-for-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@samreid @zepumph @DianaTavares and others