Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shared strings aren't showing in the test sim #361

Closed
Tracked by #888 ...
Nancy-Salpepi opened this issue Jan 23, 2023 · 5 comments
Closed
Tracked by #888 ...

Shared strings aren't showing in the test sim #361

Nancy-Salpepi opened this issue Jan 23, 2023 · 5 comments

Comments

@Nancy-Salpepi
Copy link

Test device
MacBook Air (m1 chip)

Operating System
13.1

Browser
safari 16.2

Problem description
For phetsims/qa#878, changes to shared strings don't show up when I press Test.

Steps to reproduce

  1. Choose Faroese
  2. Select Diffusion
  3. Change the name of the sim (Sim-Specific String)
  4. Change some Shared Strings
  5. Press Test --the change to the sim-specific string is there, but not the shared strings.

Visuals
Screenshot 2023-01-23 at 1 20 42 PM
Screenshot 2023-01-23 at 1 22 38 PM

@liammulh
Copy link
Member

Thanks, @Nancy-Salpepi! I wouldn't have caught this.

@liammulh liammulh changed the title Translations to Shared Strings don't appear in Preview Shared strings aren't showing in the test sim Jan 24, 2023
@liammulh
Copy link
Member

The first thing to do would be to log the translation in the client-side testTranslation.js module to ensure the shared strings are being sent to the server.

@liammulh
Copy link
Member

Well, I checked getReplacementStringObject.js before logging the translation on the client-side, and it seems the code there doesn't take shared strings into consideration. We'll need to add support for shared strings in getReplacementStringObject.js.

liammulh added a commit that referenced this issue Jan 26, 2023
@liammulh
Copy link
Member

I think done in 673ac57.

This will need thorough testing.

@stemilymill
Copy link

looks good in round 3 testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants