Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

How should we handle long strings in the translation utility? #349

Closed
liammulh opened this issue Jan 4, 2023 · 2 comments
Closed

How should we handle long strings in the translation utility? #349

liammulh opened this issue Jan 4, 2023 · 2 comments
Assignees
@oliver-phet
Labels
design:general

Comments

@liammulh
Copy link
Member

liammulh commented Jan 4, 2023 •
edited
Loading

@oliver-phet, @jbphet and I noticed a long non-a11y-description string in pH Scale:

Screen Shot 2023-01-04 at 3 32 03 PM

John and I were thinking that if we want to keep super long strings like this translatable, we should probably provide a textarea rather than an input. Thoughts?

EDIT: For context, the above screenshot was taken from ph-scale/sw (Swahili).
@oliver-phet
Copy link
Contributor

We looked at this together today. I think there is a larger discussion around validating the html tags that seem to be present in several of these.

For now, I'd opt for a textarea for handling these.

This was referenced Jan 12, 2023
Closed
Closed
Open
@liammulh liammulh mentioned this issue Feb 3, 2023
Closed
liammulh added a commit that referenced this issue Feb 3, 2023
@liammulh
feat: make inputs textarea, align copy value button
beb2136 
For #349. The original mission
for this commit was to make the inputs for long English strings be text
areas, but I think making them all text areas is a more elegant
solution.

I also aligned the copy value button and the text area using Flexbox
since it looked even weirder with the old styling and the textareas.
@liammulh
Copy link
Member Author

liammulh commented Feb 3, 2023

In beb2136, I made all inputs textareas with a default height similar to that of an input. This seemed like a more elegant solution to me. I also aligned the copy value button and the text areas. I think it looks much nicer and feels much nicer from a UX perspective.

liammulh added a commit that referenced this issue Feb 8, 2023
@liammulh
feat: make inputs textarea, align copy value button
e1622cd 
For #349. The original mission
for this commit was to make the inputs for long English strings be text
areas, but I think making them all text areas is a more elegant
solution.

I also aligned the copy value button and the text area using Flexbox
since it looked even weirder with the old styling and the textareas.
@liammulh liammulh closed this as completed Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oliver-phet oliver-phet

Labels
design:general
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@oliver-phet @liammulh