remove call to this.updateQuantities that is already handled by super…

…class, #78
phetsims · Mar 3, 2023 · 62aead6 · 62aead6
1 parent 4e7cbc6
commit 62aead6
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/js/common/model/Reaction.ts b/js/common/model/Reaction.ts
@@ -81,7 +81,7 @@ export default class Reaction {
   /*
    * Updates the quantities of products and leftovers.
    */
-  protected updateQuantities(): void {
+  private updateQuantities(): void {
     const numberOfReactions = this.getNumberOfReactions();
     this.products.forEach( product => {
       product.quantityProperty.value = numberOfReactions * product.coefficientProperty.value;

diff --git a/js/sandwiches/model/SandwichRecipe.ts b/js/sandwiches/model/SandwichRecipe.ts
@@ -59,10 +59,10 @@ export default class SandwichRecipe extends Reaction {
 
     super( [ bread, meat, cheese ], [ sandwich ], { nameProperty: nameProperty } );
 
+    // Updates the sandwich (product) icon
     Multilink.multilink(
       [ bread.coefficientProperty, meat.coefficientProperty, cheese.coefficientProperty ],
       ( breadCoefficient, meatCoefficient, cheeseCoefficient ) => {
-        this.updateQuantities();
         sandwich.iconProperty.value = this.isReaction() ?
                                       new SandwichNode( breadCoefficient, meatCoefficient, cheeseCoefficient ) :
                                       NO_SANDWICH_NODE;