Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instrument for PhET-iO #351

Closed
zepumph opened this issue Feb 15, 2021 · 3 comments
Closed

Instrument for PhET-iO #351

zepumph opened this issue Feb 15, 2021 · 3 comments
Assignees
@brettfiedler
Labels
dev:phet-io status:on-hold

Comments

@zepumph
Copy link
Member

zepumph commented Feb 15, 2021

To support research goals over in #142, basic instrumentation should be done.
@zepumph zepumph self-assigned this Feb 15, 2021
@zepumph zepumph mentioned this issue Feb 15, 2021
Closed
zepumph added a commit that referenced this issue Feb 15, 2021
@zepumph
add basic instrumentation to RAP (just the model), #351
3ca1932
zepumph added a commit to phetsims/perennial that referenced this issue Feb 15, 2021
@zepumph
add basic instrumentation to RAP (just the model), phetsims/ratio-and…
85ccba1 
…-proportion#351
zepumph added a commit that referenced this issue Feb 15, 2021
@zepumph
update readme from grunt update, #351
1ee9bd2
zepumph added a commit that referenced this issue Feb 15, 2021
@zepumph
instrument required tandems in the view, #351
ec2c61f
zepumph added a commit to phetsims/scenery-phet that referenced this issue Feb 15, 2021
@zepumph
instrument required tandems in the view, phetsims/ratio-and-proportio…
349f70b 
…n#351
@zepumph
Copy link
Member Author

zepumph commented Feb 15, 2021

The sim is now running with validation (so all required tandems are handled or opted out), and everything in the model is ready to go. CT will show if there are any more problems. I had to pass tandems because validation is required to get into rc/production, which I didn't want to write off as a possible way to proceed with the data collection.

zepumph added a commit that referenced this issue Feb 15, 2021
@zepumph
validate please, #351
688fa9b
@zepumph zepumph mentioned this issue Feb 15, 2021
Closed
@zepumph
Copy link
Member Author

zepumph commented Feb 18, 2021

Today during PhET-iO meeting, we talked about me taking this further, and doing the full first pass and then letting PhET-iO designers review. This will be useful since we already have worked on PhET-iO for this sim, might as well take it all the way for this simpler instrumentation.

zepumph added a commit that referenced this issue Feb 26, 2021
@zepumph
instrument ratioHalf inputEnabled, #351 phetsims/studio#106
a0e55a3
zepumph added a commit that referenced this issue May 4, 2021
@zepumph
instrument inProportionProperty and movingInDirectionProperty, #351 #142
01e4010
zepumph added a commit that referenced this issue May 4, 2021
@zepumph
instrument inProportionProperty and movingInDirectionProperty, #351 #142
bc77cd7
@brettfiedler brettfiedler assigned brettfiedler and unassigned zepumph Oct 20, 2021
@brettfiedler
Copy link
Member

I believe this is complete per the spirit of the issue. Updates and ongoing work will occur in #468

marlitas pushed a commit to phetsims/sun that referenced this issue Jun 28, 2022
@zepumph @marlitas
instrument required tandems in the view, phetsims/ratio-and-proportio…
fa523eb 
…n#351
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brettfiedler brettfiedler

Labels
dev:phet-io status:on-hold
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zepumph @brettfiedler