Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

phet-io overrides are set on preloads #1008

Closed
zepumph opened this issue Feb 15, 2021 · 2 comments
Closed

phet-io overrides are set on preloads #1008

zepumph opened this issue Feb 15, 2021 · 2 comments
Assignees
@samreid
Labels
status:ready-for-review

Comments

@zepumph
Copy link
Member

zepumph commented Feb 15, 2021

I found a bug in how the default overrides file is generated in chipper. It still points to phet.phetio.phetioElementsOverrides even though it is now phet.preloads.phetio.phetioElementsOverrides. There are a couple usages I will remove.

Discovered while working on phetsims/ratio-and-proportion#351
@zepumph zepumph self-assigned this Feb 15, 2021
zepumph added a commit to phetsims/ratio-and-proportion that referenced this issue Feb 15, 2021
@zepumph
add "preloads" to overrides logic, phetsims/chipper#1008
73ab7e4
zepumph added a commit that referenced this issue Feb 15, 2021
@zepumph
add "preloads" to overrides logic, #1008
15a180f
zepumph added a commit to phetsims/tandem that referenced this issue Feb 15, 2021
@zepumph
add "preloads" to overrides logic, phetsims/chipper#1008
b5b85ee
zepumph added a commit to phetsims/axon that referenced this issue Feb 15, 2021
@zepumph
add "preloads" to overrides logic, phetsims/chipper#1008
0791b26
@zepumph zepumph assigned samreid and unassigned zepumph Feb 15, 2021
@zepumph
Copy link
Member Author

zepumph commented Feb 15, 2021

@samreid please review.

@samreid
Copy link
Member

samreid commented Feb 24, 2021

Looks good, thanks! I didn't see any other occurrences that need to change. Closing.

@samreid samreid closed this as completed Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samreid samreid

Labels
status:ready-for-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@samreid @zepumph