Skip to content

Commit

Permalink
remove vertical grid lines, #23
Browse files Browse the repository at this point in the history
  • Loading branch information
zepumph committed May 18, 2020
1 parent 2060889 commit c6f865c
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions js/free-objects/view/ProportionGridNode.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ import ratioAndProportion from '../../ratioAndProportion.js';
import GridView from './GridView.js';
import designingProperties from '../../common/designingProperties.js';

const VERTICAL_SPACING = 10;
const LABEL_X = 0;

class ProportionGridNode extends GridNode {
Expand Down Expand Up @@ -54,12 +53,11 @@ class ProportionGridNode extends GridNode {
}

update( baseUnit, gridView ) {
const verticalSpacing = this.gridWidth / VERTICAL_SPACING;

// TODO: probably should try to keep this consistent across different screenView heights
// subtract one to account for potential rounding errors. This helps guarantee that the last line is drawn.
const horizontalSpacing = ( this.gridHeight - 1 ) / baseUnit;
this.setLineSpacings( null, null, verticalSpacing, horizontalSpacing );
this.setLineSpacings( null, null, null, horizontalSpacing );

this.visible = GridView.displayVertical( gridView ) || GridView.displayHorizontal( gridView );

Expand Down

0 comments on commit c6f865c

Please sign in to comment.