Keyboard Shortcuts Dialog

[terracoda]

I still need to create a keyboard shortcuts dialog.

This sim has custom interactions, and may have hot keys to get to the check boxes.

[terracoda]

@jessegreenberg, can you put in a default Keyboard Shortcuts dialog? I'll work what needs to get added.

[terracoda]

That is, if there is a "default" Keyboard Shortcuts dialog.

[jessegreenberg]

There isn't really a default one but I added some boilerplate and a dialog with "basic actions" has been added. Ready for content whenever!

[terracoda]

Thanks @jessegreenberg. That's perfect for now.

[terracoda]

Here's an initial rough draft of the Keyboard shortcuts.

I think Voicing shortcut keys will need to go somewhere else, but just noting them here as there is room in this dialog.

[terracoda]

Oh, I forgot the Space or Enter shortcut on the corners and sides.

[terracoda]

[terracoda]

This rough, and I'll post the accessible version of the content today.

[terracoda]

Oops, I didn't use a dialog with "Toggle checkboxes [Space]. This is a better draft here. I even added [Enter] key to buttons, which we really should add.

So, main question, what to do with the Voicing Shortcuts. Are the just for Voicing?

[terracoda]

@BLFiedler do you have any thoughts about whether the Check Shape, and Reset Shape shortcuts need to be Voicing specific? They should not conflict with screen reader software.And for pressing Space or Enter on a focused corner or side. I think that's how it might work with screen reader software,though I would need to double check.

[terracoda]

I'll assign to @emily-phet and @BLFiedler for comment.

[emily-phet]

I think where possible, we should avoid having modality specific shortcuts. Since Voicing is enabling a display, it would be ideal if there were corresponding displays in the visual, etc. Of course, that likely won't work across the board...but an ideal good to aim for.

I'm not sure what you're remaining questions are - or next steps for this issue. We discussed it prior to the POSE workshop and I can't recall if you still had remaining questions or needs. Let me know if that's the case. :)

[brettfiedler]

I don't think Check Shape and Reset shape need to be Voicing specific.

I'm not certain about the "Enter or Space" for re-voicing the side/corner information. I don't think we have equivalent toggle-able display (it's "always-on" visually). Might be that remains as a sole Voicing specific control?

[terracoda]

I think the Space and Enter keys for repeating the object's current state information will be pretty intuitive to learners. I'm not sure we will need to document this.

I agree that the Check Shape and Reset Shape shortcuts can be general shortcuts.

I'll update the content.

[terracoda]

@jessegreenberg, regarding the Voicing and translation issue, would this text feel better?

H2: Shape Shortcuts

• English only, with Voicing enabled Check Current Shape with ALT plus C.
• Reset Shape with ALT plus Shift plus R.

OR

H2: Shape Shortcuts

• With Voicing enabled (English only) Check Current Shape with ALT plus C.
• Reset Shape with ALT plus Shift plus R.

[jessegreenberg]

No need to change in my opinion @terracoda, this content will be totally invisible when not running in English (and when Voicing is not supported on your platform).

[terracoda]

Ok, we keep it simple, then :-)

[jessegreenberg]

I think this is ready, @terracoda can you please review the dialog now?

[jessegreenberg]

I noticed one of the strings was incorrect and missing lineWrap fixed above.

[jessegreenberg]

Also, these sections didn't have Voicing support. Added above.

[terracoda]

Reviewing.

[terracoda]

I hear longer pauses at the end of each line in the Basic Actions reading block.
If possible, it would be nice to hear longer pauses, at the end of the lines for the other reading blocks. I am not sure why the pauses re shorter.

In addition, I need to adjust the strings for Move Corner and Sides. I think I need to spell it all out like we have done in previous sims.

H2: Move Corners and Sides

• Move corner or side up, left, down, or right with Arrow keys or with letter keys W, A, S, or D.
• Move in smaller steps with Shift plus Arrow keys, or Shift plus letter keys W, A, S, or D, or Shift plus Mouse.

I'll see if I ca make the text changes myself.

[terracoda]

Ok, I made all changes to visual text in KB dialog and the A11y text in the KB dialog.

I think the nice pause happens if the line ends in an actual word and a period, like "...Tab key." or "Arrow keys.", but if the line ends with a non-word, like a letter key description, "D.", "C." or "R." there is no nice natural pause.

I'll see if an extra space after the period does anything.

[terracoda]

A space after the period does not add any extra pause from the web speech voice.

Neither Alex or Google US English voices added a pause at the end of sentences that end in a letter.

I'll remove the space.

[terracoda]

Assigning back to @jessegreenberg in case there is anything code clean-up needed.

I did change the content and order of words in the KB Shortcuts dialog. I am not sure how closely they need to match their corresponding code names.

[jessegreenberg]

Looks great! Commits were dd6ee60 9eb68f1 6f438b6 0f87d29. I did update the key names in the json, but otherwise it sounds like this is good to close.