Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pickup sounds that are different for vertex and side #128

Closed
brettfiedler opened this issue Apr 19, 2022 · 14 comments
Closed

Pickup sounds that are different for vertex and side #128

brettfiedler opened this issue Apr 19, 2022 · 14 comments

Comments

@brettfiedler
Copy link
Member

To differentiate component pickup, we'd like two different sounds for picking up a vertex vs. a side

We could start by choosing a pickup/drop set of sounds for vertex similar to Faraday's law.

Perhaps the side length sound could just be a lower set of tones? Can discuss at sound meeting.

@terracoda
Copy link
Contributor

Just an FYI, the pick up sounds in Faraday's Law represent a two-step pick-up interaction. Not sure if it is different from a one-step pick-up interaction like the Hands in RaP or typical slider interactions.

@brettfiedler
Copy link
Member Author

Note by @jessegreenberg during Sound design today:

A pickup sound could be disabled if Voicing is enabled.
Or it might sound nice when we have volume ducking with sound + voicing (issue #185)

@terracoda
Copy link
Contributor

Like Voicing, I think the pick-up sound might be really helpful for people who have trouble seeing the screen or can't see the screen, so I don't think it needs to be disabled when Voicing is enabled.

@brettfiedler
Copy link
Member Author

We liked the Ratio and Proportion sounds as a more "general" sound than Faraday's Law pick up sounds. They are a little too subtle though.

@Ashton-Morris, could you modify the pickup sounds from Ratio and Proportion to differentiate them further? Perhaps the lower tone goes lower still?

@brettfiedler
Copy link
Member Author

brettfiedler commented Oct 18, 2022

WAIT - first. @jessegreenberg, can you implement the sounds from Ratio and Proportion pickup on "mouse down" or touch pick up or on "initial tab focus" (sorry, don't know the code variables here)

  • high pitch goes to vertex (grab.mp3)
  • low pitch goes to side (release.mp3)

@jessegreenberg
Copy link
Contributor

These sounds were added, back to @BLFiedler for next steps!

@brettfiedler
Copy link
Member Author

From @terracoda's recent interview:
image

While tabbing through quickly, it was difficult to tell the difference. It won't need much, but a small tweak is fine to quickly address even based on one interview.

@Ashton-Morris , Could you raise the pitch of grab.mp3 from Ratio and Proportion just a bit to differentiate it from the lower pitched release.mp3 that is used for a side right now? I defer to your judgment on what is a small but meaningful pitch change here.

  • Raise the pitch of grab.mp3 just a bit to differentiate from release.mp3

@Ashton-Morris
Copy link

I have added theses sounds in this folder.

Some I have added a slight click to them to differentiate them a bit more. Choose your favorite one.

  • grab-v5.mp3
  • grab-v4.mp3
  • grab-v3.mp3
  • grab-v2.mp3

@brettfiedler
Copy link
Member Author

brettfiedler commented Dec 20, 2022

@jessegreenberg,

  • Let's replace the vertex pickup sound with grab-v2.mp3 in the folder Ashton linked.

@jessegreenberg
Copy link
Contributor

OK, new sound for grabbing Vertices was added to the sim (grab-v2.mp3). @Ashton-Morris @BLFiedler can you please review?

@brettfiedler
Copy link
Member Author

Sounds good to me. Definitely a clear difference, but they share enough quality to be the same interaction.

We discussed changing the sounds levels a bit for these and the boundary sounds. I gave that a try in the commit above.

@Ashton-Morris
Copy link

Sounds good to me as well. @jessegreenberg I would lower the corner sound down about 10% though since it is higher in pitch. Can you do that?

@brettfiedler
Copy link
Member Author

Done! To make any real effectual change I went a bit further (0.8 -> 0.6). Did you want to review, @Ashton-Morris?

@brettfiedler brettfiedler removed their assignment Jan 23, 2023
@Ashton-Morris
Copy link

Just checked and the changes sound good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants