Skip to content

Commit

Permalink
using higher pitch grab sound for Vertices, see #128
Browse files Browse the repository at this point in the history
  • Loading branch information
jessegreenberg committed Dec 27, 2022
1 parent b99e396 commit a90f4af
Show file tree
Hide file tree
Showing 4 changed files with 59 additions and 5 deletions.
10 changes: 5 additions & 5 deletions js/quadrilateral/view/VertexNode.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import PickRequired from '../../../../phet-core/js/types/PickRequired.js';
import QuadrilateralQueryParameters from '../QuadrilateralQueryParameters.js';
import QuadrilateralConstants from '../../common/QuadrilateralConstants.js';
import SoundClip from '../../../../tambo/js/sound-generators/SoundClip.js';
import grab_mp3 from '../../../../tambo/sounds/grab_mp3.js';
import grabHighPitch_mp3 from '../../../sounds/grabHighPitch_mp3.js';
import boundaryReached_mp3 from '../../../../tambo/sounds/boundaryReached_mp3.js';
import soundManager from '../../../../tambo/js/soundManager.js';
import quadrilateral from '../../quadrilateral.js';
Expand Down Expand Up @@ -209,10 +209,10 @@ class VertexNode extends Voicing( Circle ) {
}
} );


// sound - the grab sound is played on press but there is no release sound for this component since there is
// no behavioral relevance to the release
const pressedSoundPlayer = new SoundClip( grab_mp3 );
// sound - The grab sound is played on press but there is no release sound for this component since there is
// no behavioral relevance to the release. Uses a custom "higher pitch" sound to distinguish it from
// sides.
const pressedSoundPlayer = new SoundClip( grabHighPitch_mp3 );
soundManager.addSoundGenerator( pressedSoundPlayer );
vertex.isPressedProperty.lazyLink( isPressed => {
if ( isPressed ) {
Expand Down
Binary file added sounds/grabHighPitch.mp3
Binary file not shown.
46 changes: 46 additions & 0 deletions sounds/grabHighPitch_mp3.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 8 additions & 0 deletions sounds/license.json
Original file line number Diff line number Diff line change
Expand Up @@ -274,5 +274,13 @@
"projectURL": "https://phet.colorado.edu",
"license": "contact [email protected]",
"notes": "created by Ashton Morris (PhET Interactive Simulations)"
},
"grabHighPitch.mp3": {
"text": [
"Copyright 2002-2022 University of Colorado Boulder"
],
"projectURL": "https://phet.colorado.edu",
"license": "contact [email protected]",
"notes": "created by Ashton Morris (PhET Interactive Simulations)"
}
}

0 comments on commit a90f4af

Please sign in to comment.