-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RC Spot Check: Build-A-Molecule 1.0.0-rc.2 #538
Comments
Making this top priority, since it is a spot check and it would be super exciting to get this sim published |
Since this is a spot check a greyed out some of the rows in the test matrix |
@KatieWoe can you give me edit access to the test matrix? I'll test macOS 10.15. |
You should have access now. |
@ariel-phet I spent a lot of time testing BAM today, and unfortunately I did find a science/model bug related to double bonds sometimes showing up a single bonds. I don't have access to the remaining platforms in the test matrix, so I'll go ahead and unassign myself. |
The context for this issue's resolution is noted here: phetsims/build-a-molecule#207 (comment) |
@KatieWoe just noting that this is a top priority for me, not for you :) |
Also noting that the sim may benefit from the expanded touch area for the x to get out of dialogs. |
QA is done. |
Thanks a bunch for the work QA and associates. I have opened a new spot check issue for the comments above and the one remaining opened issue. |
@ariel-phet , @arouinfar , Build-A-Molecule/1.0.0-rc.2 is ready for RC testing. There was already a fair amount of testing done on this sim and not a significant amount of code changes as a result. A full RC isn't required but a few issues should be verified in this spot check. This build is not expected to be shared with clients but instead moved through the production pipeline. Document issues in https://github.com/phetsims/build-a-molecule/issues and link to this
issue.
Assigning to @ariel-phet for prioritization.
Focus and Special Instructions
There were refactors to the use of WebGL contexts for the molecule dialogs. Please be sure to pay attention to the 3D molecule dialogs' appearance and behavior. These dialogs can be opened via the green 3D button near built molecules.
Issues to Verify
These issues should have the "status:ready-for-qa" label. Check these issues off and close them if they are fixed.
Otherwise, post a comment in the issue saying that it wasn't fixed and link back to this issue. If the label is
"status:ready-for-review" or "status:fixed-pending-deploy" then assign back to the developer when done, even if fixed.
Link(s)
FAQs for QA Members
There are multiple tests in this issue... Which test should I do first?
Test in order! Test the first thing first, the second thing second, and so on.
How should I format my issue?
Here's a template for making issues:
Who should I assign?
We typically assign the developer who opened the issue in the QA repository.
My question isn't in here... What should I do?
You should:
The text was updated successfully, but these errors were encountered: