Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RC Spot Check: Build-A-Molecule 1.0.0-rc.2 #538

Closed
3 tasks done
Denz1994 opened this issue Aug 26, 2020 · 11 comments
Closed
3 tasks done

RC Spot Check: Build-A-Molecule 1.0.0-rc.2 #538

Denz1994 opened this issue Aug 26, 2020 · 11 comments
Assignees

Comments

@Denz1994
Copy link
Contributor

Denz1994 commented Aug 26, 2020

@ariel-phet , @arouinfar , Build-A-Molecule/1.0.0-rc.2 is ready for RC testing. There was already a fair amount of testing done on this sim and not a significant amount of code changes as a result. A full RC isn't required but a few issues should be verified in this spot check. This build is not expected to be shared with clients but instead moved through the production pipeline. Document issues in https://github.com/phetsims/build-a-molecule/issues and link to this
issue.

Assigning to @ariel-phet for prioritization.

Focus and Special Instructions

There were refactors to the use of WebGL contexts for the molecule dialogs. Please be sure to pay attention to the 3D molecule dialogs' appearance and behavior. These dialogs can be opened via the green 3D button near built molecules.

Issues to Verify

These issues should have the "status:ready-for-qa" label. Check these issues off and close them if they are fixed.
Otherwise, post a comment in the issue saying that it wasn't fixed and link back to this issue. If the label is
"status:ready-for-review" or "status:fixed-pending-deploy" then assign back to the developer when done, even if fixed.

Link(s)


FAQs for QA Members
There are multiple tests in this issue... Which test should I do first?

Test in order! Test the first thing first, the second thing second, and so on.


How should I format my issue?

Here's a template for making issues:

  <b>Test Device</b>

  blah

  <b>Operating System</b>

  blah

  <b>Browser</b>

  blah

  <b>Problem Description</b>

  blah

  <b>Steps to Reproduce</b>

  blah

  <b>Visuals</b>

  blah

  <details>
  <summary><b>Troubleshooting Information</b></summary>

  blah

  </details>

Who should I assign?

We typically assign the developer who opened the issue in the QA repository.


My question isn't in here... What should I do?

You should:

  1. Consult the QA Book.
  2. Google it.
  3. Ask Katie.
  4. Ask a developer.
  5. Google it again.
  6. Cry.


@ariel-phet
Copy link
Contributor

Making this top priority, since it is a spot check and it would be super exciting to get this sim published

@KatieWoe
Copy link
Contributor

Since this is a spot check a greyed out some of the rows in the test matrix

@arouinfar
Copy link
Contributor

@KatieWoe can you give me edit access to the test matrix? I'll test macOS 10.15.

@KatieWoe
Copy link
Contributor

You should have access now.

@arouinfar
Copy link
Contributor

@ariel-phet I spent a lot of time testing BAM today, and unfortunately I did find a science/model bug related to double bonds sometimes showing up a single bonds. I don't have access to the remaining platforms in the test matrix, so I'll go ahead and unassign myself.

@arouinfar arouinfar removed their assignment Aug 27, 2020
@Denz1994
Copy link
Contributor Author

I did find a science/model bug related to double bonds sometimes showing up a single bonds

The context for this issue's resolution is noted here: phetsims/build-a-molecule#207 (comment)

@ariel-phet
Copy link
Contributor

@KatieWoe just noting that this is a top priority for me, not for you :)

@KatieWoe
Copy link
Contributor

KatieWoe commented Sep 11, 2020

Had the sim crash and restart on iPadOS 13.7 after 3 minutes or so, but it was on ?showPointerAreas which lowers performance. @Denz1994 let me know if you think this is issue worthy.

Edit: Had this happen with ?stringTest=rtl which is less expected. @Denz1994 is this issue worthy?

@KatieWoe
Copy link
Contributor

Also noting that the sim may benefit from the expanded touch area for the x to get out of dialogs.

@KatieWoe
Copy link
Contributor

QA is done.

@ariel-phet ariel-phet removed their assignment Sep 15, 2020
Denz1994 added a commit to phetsims/build-a-molecule that referenced this issue Sep 16, 2020
@Denz1994
Copy link
Contributor Author

Thanks a bunch for the work QA and associates. I have opened a new spot check issue for the comments above and the one remaining opened issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants