Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Atoms and Buckets seem to shake while manipulating molecules in the play area #202

Closed
loganbraywork opened this issue Jul 1, 2020 · 6 comments
Labels

Comments

@loganbraywork
Copy link

Test device

Windows 10 laptop

Operating System

Windows 10 v. 1903

Browser

Edge v.83.0.478.56

Problem description

For phetsims/qa#509

Appears on Chrome as well. Does NOT appear in Firefox. Atoms in the buckets in the Playground screen seem to jump or shake when molecules or atoms are manipulated in the play area. I've noticed that this seems to occur when the atoms are moved while in the upper half of the play area, as opposed to the lower half.

Steps to reproduce

  1. Enter the Playground screen
  2. Using the arrows next to the buckets, switch to the 5th set of buckets (featuring only 1 phosphorus)
  3. Remove the phosphorus from the bucket and drag it around the upper half of the play area

Visuals

2020-07-01BldMlclAtomJumping

Troubleshooting information:
!!!!! DO NOT EDIT !!!!!
Name: ‪Build a Molecule‬
URL: https://phet-dev.colorado.edu/html/build-a-molecule/1.0.0-rc.1/phet/build-a-molecule_all_phet.html
Version: 1.0.0-rc.1 2020-06-19 20:40:00 UTC
Features missing: touch
Flags: pixelRatioScaling
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/83.0.4103.116 Safari/537.36 Edg/83.0.478.56
Language: en-US
Window: 1313x647
Pixel Ratio: 1.4625000953674316/1
WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium)
GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium)
Vendor: WebKit (WebKit WebGL)
Vertex: attribs: 16 varying: 30 uniform: 4095
Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32)
Max viewport: 32767x32767
OES_texture_float: true
Dependencies JSON: {}

@Denz1994
Copy link
Contributor

Denz1994 commented Jul 16, 2020

An initial investigation doesn't indicate that atom positions, destinations, or atomNode translations aren't being updated while in the buckets. Also, this isn't just related to the buckets or atoms because the carousel, page navigation, and resetAllButton is also shaking in the gif. The next steps would be to check for changing Bounds (carousel, layout bounds, and play area).

As a side note, I can't replicate this buggy behavior on my local machine (windows or mac).

@Denz1994
Copy link
Contributor

I've exhausted checking for bounds or position changes of all view components on the playground screen while dragging items as described above. These values aren't changing and I can't replicate this behavior locally. I've also tried replicating on two mobile devices, two windows devices, and my primary dev machine (MacBook) with no success. If this was a performance issue it should be evident on a mobile device.

Passing this back to QA to make sure this can still be replicated. Perhaps there is a different set of instructions to follow to reproduce this bug. I find it odd that this wasn't caught in phetsims/qa#506 being that this dev-test came right before this RC with little code changes in between.

@KatieWoe Can this be tested again to verify this can be replicated with the above steps? I'm having trouble reproducing this bug.

@loganbraywork
Copy link
Author

The laptop I used for testing in which I found this issue has a large screen. This may be the cause of the shaking. I did test this issue when the window is not fully expanded, and the same shaking does occur.

@KatieWoe
Copy link
Contributor

I looked on master on Win 10 Chrome and didn't see anything. But also can't really see it in the gif. As such I'm going to assign @loganbraywork to work with @Denz1994 on this.

@KatieWoe KatieWoe assigned Denz1994 and loganbraywork and unassigned KatieWoe Jul 28, 2020
@Denz1994
Copy link
Contributor

Should be verified by the latest RC.

@ariel-phet
Copy link

I checked this on Win 10 edge, not seeing anything. Could be device specific, since neither myself, @Denz1994 @KatieWoe has seen this, it is not worth pursuing further. Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants