Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev Test: circuit-construction-kit-dc/1.0.0-dev.166 #51

Closed
samreid opened this issue Sep 19, 2017 · 10 comments
Closed

Dev Test: circuit-construction-kit-dc/1.0.0-dev.166 #51

samreid opened this issue Sep 19, 2017 · 10 comments
Assignees
Labels
QA:dev-test Dev test before an RC

Comments

@samreid
Copy link
Member

samreid commented Sep 19, 2017

In #48 (comment) @phet-steele said:

@samreid we could do with a new dev version when you get the chance. It doesn't appear that phetsims/circuit-construction-kit-dc#96 is fixed in master yet.

phetsims/circuit-construction-kit-dc#96 is fixed and phetsims/circuit-construction-kit-common#404 is fixed pending review. I published a new dev version here:
SEE BELOW

Reassigned to @ariel-phet so he is aware of the status of CCK, and to set priority/schedule for this 2nd dev test.

@samreid samreid added the QA:dev-test Dev test before an RC label Sep 19, 2017
@samreid
Copy link
Member Author

samreid commented Sep 19, 2017

In phetsims/axon#140 @jessegreenberg identified an issue that may lead to a memory leak. So I'm going to post dev.162 here and update this issue to refer to it:
SEE BELOW

@samreid samreid changed the title Dev Test: circuit-construction-kit-dc/1.0.0-dev.161 Dev Test: circuit-construction-kit-dc/1.0.0-dev.162 Sep 19, 2017
@ariel-phet ariel-phet assigned phet-steele and unassigned ariel-phet Sep 19, 2017
@ariel-phet
Copy link
Contributor

@phet-steele definitely top priority

@samreid
Copy link
Member Author

samreid commented Sep 26, 2017

@phet-steele can I get a status update on this issue?

@phet-steele
Copy link
Contributor

@samreid it's coming along pretty well. You do want phetsims/circuit-construction-kit-dc#62 checked, right?

@samreid
Copy link
Member Author

samreid commented Sep 27, 2017

Yes please, I added a note in its comment thread.

@phet-steele
Copy link
Contributor

@samreid, can QA get a dev.166 and a new issue (so we can stop testing on master)?

@samreid
Copy link
Member Author

samreid commented Oct 11, 2017

@samreid samreid assigned phet-steele and unassigned samreid Oct 11, 2017
@phet-steele phet-steele changed the title Dev Test: circuit-construction-kit-dc/1.0.0-dev.162 Dev Test: circuit-construction-kit-dc/1.0.0-dev.166 Oct 11, 2017
@samreid
Copy link
Member Author

samreid commented Oct 15, 2017

The non-deferred issues are fixed pending testing, back to you @phet-steele.

@phet-steele
Copy link
Contributor

@samreid

RC please 🔋 ⚡️ 💡 🌞

@phet-steele
Copy link
Contributor

RC is out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA:dev-test Dev test before an RC
Projects
None yet
Development

No branches or pull requests

3 participants