Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Lab screen icon #162

Closed
phet-steele opened this issue Oct 3, 2017 · 4 comments
Closed

Update Lab screen icon #162

phet-steele opened this issue Oct 3, 2017 · 4 comments
Assignees
@arouinfar
Labels
design:artwork status:ready-for-review

Comments

@phet-steele
Copy link
Contributor

#88 rotated the voltmeter probes. @samreid @arouinfar, does this mean we should update the Lab screen icon? The icon's probes are still not rotated. https://github.com/phetsims/circuit-construction-kit-dc/blob/master/images/lab-screen-icon.png

For phetsims/qa/issues/51.
@samreid
Copy link
Member

samreid commented Oct 3, 2017

It looks like this was generated from the sim, I can try to update it.

@arouinfar
Copy link
Contributor

Sounds good. Thanks @samreid.

@arouinfar arouinfar removed their assignment Oct 3, 2017
samreid added a commit that referenced this issue Oct 3, 2017
@samreid
Updated the lab screen icon (with rotated probes), see #162
c7fb2ec
@samreid
Copy link
Member

samreid commented Oct 3, 2017

Updated in the preceding commit, @arouinfar can you please review on phettest?

@samreid samreid assigned arouinfar and unassigned samreid Oct 3, 2017
@arouinfar
Copy link
Contributor

@phet-steele and I approve! Thanks @samreid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arouinfar arouinfar

Labels
design:artwork status:ready-for-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@samreid @phet-steele @arouinfar