Maintenance Testing: Broken locales on Safari SVG #1039
Assignees
Comments
|
Patch for perennial for the above list generation: Subject: [PATCH] Custom list for https://github.com/phetsims/qa/issues/1039
---
Index: js/common/ModifiedBranch.js
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/js/common/ModifiedBranch.js b/js/common/ModifiedBranch.js
--- a/js/common/ModifiedBranch.js (revision 31500e622ab44154dd93c6078649f0e21cdfc856)
+++ b/js/common/ModifiedBranch.js (date 1707782446826)
@@ -15,6 +15,8 @@
const gitPull = require( './gitPull' );
const githubCreateIssue = require( './githubCreateIssue' );
const assert = require( 'assert' );
+const simMetadata = require( '../common/simMetadata' );
+const localeInfo = require( '../../../chipper/js/data/localeInfo' );
module.exports = ( function() {
@@ -178,42 +180,54 @@
async getDeployedLinkLines( includeMessages = true ) {
assert( this.deployedVersion !== null );
- const linkSuffixes = [];
+ const metadata = await simMetadata();
+
+ const locales = Object.keys( metadata.projects.find( project => {
+ return project.simulations.length === 1 && project.simulations[ 0 ].name === this.repo;
+ } ).simulations[ 0 ].localizedSimulations ).filter( locale => {
+ return [
+ // broken locales
+ 'bn', 'bo', 'gu', 'hi', 'km', 'kn', 'ml', 'mr', 'or', 'si', 'ta', 'te', 'th',
+
+ // other test locales (either English, or popular RTL languages that might be affected)
+ 'en', 'ar_SA', 'iw', 'fa'
+ ].includes( locale );
+ } );
+
const versionString = this.deployedVersion.toString();
const standaloneParams = await this.releaseBranch.getPhetioStandaloneQueryParameter();
- const proxiesParams = ( await this.releaseBranch.usesRelativeSimPath() ) ? 'relativeSimPath' : 'launchLocalVersion';
- const studioName = ( this.brands.includes( 'phet-io' ) && await this.releaseBranch.usesPhetioStudio() ) ? 'studio' : 'instance-proxies';
- const studioNameBeautified = studioName === 'studio' ? 'Studio' : 'Instance Proxies';
const usesChipper2 = await this.releaseBranch.usesChipper2();
const phetFolder = usesChipper2 ? '/phet' : '';
const phetioFolder = usesChipper2 ? '/phet-io' : '';
const phetSuffix = usesChipper2 ? '_phet' : '';
const phetioSuffix = usesChipper2 ? '_all_phet-io' : '_en-phetio';
const phetioBrandSuffix = usesChipper2 ? '' : '-phetio';
- const studioPathSuffix = ( await this.releaseBranch.usesPhetioStudioIndex() ) ? '' : `/${studioName}.html?sim=${this.repo}&${proxiesParams}`;
const phetioDevVersion = usesChipper2 ? versionString : versionString.split( '-' ).join( '-phetio' );
- if ( this.deployedVersion.testType === 'rc' ) {
- if ( this.brands.includes( 'phet' ) ) {
- linkSuffixes.push( `](https://phet-dev.colorado.edu/html/${this.repo}/${versionString}${phetFolder}/${this.repo}_all${phetSuffix}.html)` );
- }
- if ( this.brands.includes( 'phet-io' ) ) {
- linkSuffixes.push( ` phet-io](https://phet-dev.colorado.edu/html/${this.repo}/${phetioDevVersion}${phetioFolder}/${this.repo}${phetioSuffix}.html?${standaloneParams})` );
- linkSuffixes.push( ` phet-io ${studioNameBeautified}](https://phet-dev.colorado.edu/html/${this.repo}/${phetioDevVersion}${phetioFolder}/wrappers/${studioName}${studioPathSuffix})` );
- }
- }
- else {
- if ( this.brands.includes( 'phet' ) ) {
- linkSuffixes.push( `](https://phet.colorado.edu/sims/html/${this.repo}/${versionString}/${this.repo}_all.html)` );
- }
- if ( this.brands.includes( 'phet-io' ) ) {
- linkSuffixes.push( ` phet-io](https://phet-io.colorado.edu/sims/${this.repo}/${versionString}${phetioBrandSuffix}/${this.repo}${phetioSuffix}.html?${standaloneParams})` );
- linkSuffixes.push( ` phet-io ${studioNameBeautified}](https://phet-io.colorado.edu/sims/${this.repo}/${versionString}${phetioBrandSuffix}/wrappers/${studioName}${studioPathSuffix})` );
+ const results = locales.map( locale => {
+ let link;
+ if ( this.deployedVersion.testType === 'rc' ) {
+ if ( this.brands.includes( 'phet' ) ) {
+ link = `https://phet-dev.colorado.edu/html/${this.repo}/${versionString}${phetFolder}/${this.repo}_all${phetSuffix}.html?locale=${locale}`;
+ }
+ if ( this.brands.includes( 'phet-io' ) ) {
+ link = `https://phet-dev.colorado.edu/html/${this.repo}/${phetioDevVersion}${phetioFolder}/${this.repo}${phetioSuffix}.html?${standaloneParams}&locale=${locale}`;
+ }
+ }
+ else {
+ if ( this.brands.includes( 'phet' ) ) {
+ link = `https://phet.colorado.edu/sims/html/${this.repo}/${versionString}/${this.repo}_all.html?locale=${locale}`;
+ }
+ if ( this.brands.includes( 'phet-io' ) ) {
+ link = `https://phet-io.colorado.edu/sims/${this.repo}/${versionString}${phetioBrandSuffix}/${this.repo}${phetioSuffix}.html?${standaloneParams}&locale=${locale}`;
+ }
}
- }
+ if ( link ) {
+ return `- [ ] [${locale} ${localeInfo[ locale ].name}](${link})`;
+ }
+ } ).filter( str => !!str );
- const results = linkSuffixes.map( link => `- [ ] [${this.repo} ${versionString}${link}` );
if ( includeMessages ) {
results.unshift( `\n**${this.repo} ${this.branch}** (${this.pushedMessages.join( ', ' )})\n` );
} |
This was referenced Feb 14, 2024
|
@jonathanolson I'm seeing really bad artifacts with some of these locales (ex. Kannada, Telugu) with CCK-DC that I can't replicate on published....do you think this is related to this MR? pictures
|
|
On hold while JO looks for potential workaround for safari artifacts and also into a fix for incorrect Hindi symbol https://github.com/phetsims/website-meteor/issues/656#issuecomment-1950277712 |
|
JO said since the pipeline is empty we can resume testing but skipping locales that we have seen issues with until a workaround is presented. |
jonathanolson
added a commit
to phetsims/scenery
that referenced
this issue
Feb 28, 2024
jonathanolson
added a commit
to phetsims/scenery
that referenced
this issue
Feb 29, 2024
jonathanolson
added a commit
to phetsims/scenery
that referenced
this issue
Feb 29, 2024
jonathanolson
added a commit
to phetsims/scenery
that referenced
this issue
Feb 29, 2024
jonathanolson
added a commit
to phetsims/scenery
that referenced
this issue
Feb 29, 2024
jonathanolson
added a commit
to phetsims/scenery
that referenced
this issue
Feb 29, 2024
jonathanolson
added a commit
to phetsims/scenery
that referenced
this issue
Feb 29, 2024
jonathanolson
added a commit
to phetsims/scenery
that referenced
this issue
Feb 29, 2024
jonathanolson
added a commit
to phetsims/scenery
that referenced
this issue
Feb 29, 2024
jonathanolson
added a commit
to phetsims/scenery
that referenced
this issue
Feb 29, 2024
jonathanolson
added a commit
to phetsims/scenery
that referenced
this issue
Feb 29, 2024
jonathanolson
added a commit
to phetsims/scenery
that referenced
this issue
Feb 29, 2024
jonathanolson
added a commit
to phetsims/scenery
that referenced
this issue
Feb 29, 2024
jonathanolson
added a commit
to phetsims/scenery
that referenced
this issue
Feb 29, 2024
jonathanolson
added a commit
to phetsims/scenery
that referenced
this issue
Feb 29, 2024
jonathanolson
added a commit
to phetsims/scenery
that referenced
this issue
Feb 29, 2024
jonathanolson
added a commit
to phetsims/scenery
that referenced
this issue
Feb 29, 2024
jonathanolson
added a commit
to phetsims/scenery
that referenced
this issue
Feb 29, 2024
jonathanolson
added a commit
to phetsims/scenery
that referenced
this issue
Feb 29, 2024
jonathanolson
added a commit
to phetsims/scenery
that referenced
this issue
Feb 29, 2024
jonathanolson
added a commit
to phetsims/scenery
that referenced
this issue
Feb 29, 2024
jonathanolson
added a commit
to phetsims/scenery
that referenced
this issue
Feb 29, 2024
jonathanolson
added a commit
to phetsims/scenery
that referenced
this issue
Feb 29, 2024
jonathanolson
added a commit
to phetsims/scenery
that referenced
this issue
Feb 29, 2024
jonathanolson
added a commit
to phetsims/scenery
that referenced
this issue
Feb 29, 2024
jonathanolson
added a commit
to phetsims/scenery
that referenced
this issue
Feb 29, 2024
jonathanolson
added a commit
to phetsims/scenery
that referenced
this issue
Feb 29, 2024
jonathanolson
added a commit
to phetsims/scenery
that referenced
this issue
Feb 29, 2024
jonathanolson
added a commit
to phetsims/scenery
that referenced
this issue
Feb 29, 2024
jonathanolson
added a commit
to phetsims/scenery
that referenced
this issue
Feb 29, 2024
jonathanolson
added a commit
to phetsims/scenery
that referenced
this issue
Feb 29, 2024
jonathanolson
added a commit
to phetsims/scenery
that referenced
this issue
Feb 29, 2024
jonathanolson
added a commit
to phetsims/scenery
that referenced
this issue
Feb 29, 2024
jonathanolson
added a commit
to phetsims/scenery
that referenced
this issue
Feb 29, 2024
jonathanolson
added a commit
to phetsims/scenery
that referenced
this issue
Feb 29, 2024
|
Closing, superseded by #1052. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is the maintenance release for #1036 / https://github.com/phetsims/website-meteor/issues/656, fixing the workaround for phetsims/collision-lab#177.
Testing should presumably be similar to #1036, however it's a bit trickier to generate links in this case (since they have different formats). I'm self-assigning so I can generate a better list of links that can be spot-tested.
It should only affect SVG-displayed text in Safari. Perhaps it would be good to have a call to discuss how/what to test.
The "normal" maintenance links generated are below:
The text was updated successfully, but these errors were encountered: