-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Screen titles in nav bar can be cut off with some locales #952
Comments
Also seen with: (this comment will be continually updated)
|
Just to verify, this is more "text goes off the screen, or is blocked by other components", and is more of a layout issue, right? This looks more like we'll need to make some fine adjustments to how text is handled in both cases. Previous work in #143. It's a bit complicated, I'll need to get the "accurate" bounds of the text, and only adjust things if they would go off the screen (or overlap). |
This is too much of a corner case / hard to fix, we will defer for now. Perhaps if Alpenglow has better textbounds some day. |
If relevant, Scenery can now get the improved text bounds (Text.boundsMethod='accurate'), but fine with the defer. |
Let's defer. Maybe this would be a nice issue for SceneryStack contributor in the future - perhaps. |
Test device
MacBook Air M1 chip
Operating System
14.3.1
Browser
Safari 17.3.1 and Chrome
Problem description
Seen while testing phetsims/qa#1039, the title of the screen name may be cut off slightly. So far I have seen this with locale=kn (Kannada) but will update as I continue testing.
This issue is seen with both safari and Chrome and thus not related to changes made for this MR.
Visuals
It appears in published for Center and Variability but not for Acid Base Solutions with mac + Chrome.
The text was updated successfully, but these errors were encountered: