Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screen titles in nav bar can be cut off with some locales #952

Open
Nancy-Salpepi opened this issue Feb 14, 2024 · 6 comments
Open

Screen titles in nav bar can be cut off with some locales #952

Nancy-Salpepi opened this issue Feb 14, 2024 · 6 comments

Comments

@Nancy-Salpepi
Copy link

Nancy-Salpepi commented Feb 14, 2024

Test device
MacBook Air M1 chip

Operating System
14.3.1

Browser
Safari 17.3.1 and Chrome

Problem description
Seen while testing phetsims/qa#1039, the title of the screen name may be cut off slightly. So far I have seen this with locale=kn (Kannada) but will update as I continue testing.

This issue is seen with both safari and Chrome and thus not related to changes made for this MR.

Visuals
Screenshot 2024-02-14 at 9 43 13 AM

It appears in published for Center and Variability but not for Acid Base Solutions with mac + Chrome.

@Nancy-Salpepi
Copy link
Author

Nancy-Salpepi commented Feb 14, 2024

Also seen with: (this comment will be continually updated)

  • Telugu
  • Gujarati

@KatieWoe
Copy link

I noticed that some Thai characters could get cut off on the home screen, such as in Waves Intro. However, this seems to happen on Chrome on the published sim so I don't think it is related to this change.
Screenshot 2024-02-14 at 11 33 53 AM

@jonathanolson
Copy link
Contributor

Just to verify, this is more "text goes off the screen, or is blocked by other components", and is more of a layout issue, right?

This looks more like we'll need to make some fine adjustments to how text is handled in both cases. Previous work in #143.

It's a bit complicated, I'll need to get the "accurate" bounds of the text, and only adjust things if they would go off the screen (or overlap).

@kathy-phet
Copy link

This is too much of a corner case / hard to fix, we will defer for now. Perhaps if Alpenglow has better textbounds some day.

@jonathanolson
Copy link
Contributor

If relevant, Scenery can now get the improved text bounds (Text.boundsMethod='accurate'), but fine with the defer.

@kathy-phet
Copy link

Let's defer. Maybe this would be a nice issue for SceneryStack contributor in the future - perhaps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants