Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reset the stopwatch when switching fields #320

Closed
Tracked by #1082
matthew-blackman opened this issue Apr 30, 2024 · 3 comments
Closed
Tracked by #1082

Reset the stopwatch when switching fields #320

matthew-blackman opened this issue Apr 30, 2024 · 3 comments
Assignees
@matthew-blackman
Labels
status:ready-for-review status:ready-to-cherry-pick

Comments

@matthew-blackman
Copy link
Contributor

In #297, it was discovered that it doesn't make sense to keep the stopwatch running when switching fields. The timed projectile is no longer visible, so the timer doesn't apply. We don't want to introduce a field-specific timer state for the sake of simplicity. Let's clear and pause the stopwatch when switching fields to save the user a click.
@matthew-blackman matthew-blackman mentioned this issue Apr 30, 2024
Closed
matthew-blackman added a commit that referenced this issue Apr 30, 2024
@matthew-blackman
Reset the stopwatch when switching fields - see #320
8f7a3fb
samreid pushed a commit that referenced this issue Apr 30, 2024
@matthew-blackman @samreid
Reset the stopwatch when switching fields - see #320
550aaa9 
(cherry picked from commit 8f7a3fb)
@samreid
Copy link
Member

samreid commented Apr 30, 2024

Cherry picked in both sims.

samreid referenced this issue in phetsims/projectile-sampling-distributions Apr 30, 2024
@samreid
Update dependencies.json, see phetsims/projectile-data-lab#319
3c2080c
@samreid
Copy link
Member

samreid commented Apr 30, 2024

Discovered in phetsims/qa#1079

@matthew-blackman matthew-blackman mentioned this issue May 2, 2024
Closed
16 tasks
@KatieWoe
Copy link

KatieWoe commented May 2, 2024

Looks good in rc.3

@KatieWoe KatieWoe closed this as completed May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matthew-blackman matthew-blackman

Labels
status:ready-for-review status:ready-to-cherry-pick
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@samreid @KatieWoe @matthew-blackman