Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should the histogram sound button be disabled when sound is off? #319

Closed
Tracked by #1082 ...
Nancy-Salpepi opened this issue Apr 30, 2024 · 3 comments
Closed
Tracked by #1082 ...

Comments

@Nancy-Salpepi
Copy link

Test device
MacBook Air M1 chip

Operating System
14.4.1

Browser
Safari 17.4.1

Problem description
For phetsims/qa#1079, I noticed that the histogram sound button is still enabled when the sound is off.
I looked at Number Compare and Number Play and the Sound button (megaphone) is disabled when the sound is off.

Steps to reproduce

  1. On any screen launch some projectiles
  2. Turn off the sound in the nav bar

Visuals

Here is what Number Play looks like:

soundOff.mp4
@matthew-blackman
Copy link
Contributor

Great find @Nancy-Salpepi! This is fixed in the commit, and we also added a line of code to stop the histogram data sound/animation highlighting when the sim is muted. Can you test/confirm that this is working correctly on main?

samreid pushed a commit that referenced this issue Apr 30, 2024
samreid added a commit to phetsims/projectile-sampling-distributions that referenced this issue Apr 30, 2024
samreid added a commit to phetsims/projectile-sampling-distributions that referenced this issue Apr 30, 2024
@Nancy-Salpepi
Copy link
Author

Looks good on main in both sims!

@KatieWoe
Copy link

KatieWoe commented May 2, 2024

Looks good in both

@KatieWoe KatieWoe closed this as completed May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants