Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using new ResetAllButton.isResettingAllProperty #290

Closed
Tracked by #1079
jbphet opened this issue Apr 11, 2024 · 5 comments
Closed
Tracked by #1079

Consider using new ResetAllButton.isResettingAllProperty #290

jbphet opened this issue Apr 11, 2024 · 5 comments

Comments

@jbphet
Copy link
Contributor

jbphet commented Apr 11, 2024

In phetsims/tambo#190 I added a static isResettingAllProperty flag to ResetAllButton. In subsequently looking through the codebase for opportunities to use it, I found the file isResettingAllProperty.ts in projectile-data-lab. I though y'all might want to know that there is now a common code version of this that might be a suitable replacement.

@samreid
Copy link
Member

samreid commented Apr 15, 2024

Fixed and working well in my testing. @matthew-blackman do you mind double checking? If it seems good, please label for cherry-picking and we can request QA testing in main or RC.2.

@matthew-blackman
Copy link
Contributor

Interval tool sound is still behaving correctly on reset and the code looks good. Nice improvement. Marking to cherry-pick.

@matthew-blackman matthew-blackman removed their assignment Apr 16, 2024
matthew-blackman pushed a commit that referenced this issue Apr 22, 2024
@matthew-blackman
Copy link
Contributor

Please close after verifying.

@KatieWoe
Copy link

I had a fairly bad instance of freezing with multitouch. I saw it on iPad, and don't have a touch screen on my computer, so I don't have a console readout.

Steps:

  1. Go to the third screen and turn on the interval tools.
  2. Drag around one of the ends of the tool,
  3. While dragging, press reset all, make sure the dragging finger is moving at this point
  4. With that finger still down, turn on interval tools again
  5. Drag the down finger over the tool to snag it and drag it. It should catch the "middle" of the tool
  6. Press reset all again.
RPReplay_Final1714416250.MP4

@samreid samreid self-assigned this Apr 29, 2024
@matthew-blackman
Copy link
Contributor

Continuing multitouch behavior in #321. This issue can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants