-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider using new ResetAllButton.isResettingAllProperty
#290
Comments
Fixed and working well in my testing. @matthew-blackman do you mind double checking? If it seems good, please label for cherry-picking and we can request QA testing in main or RC.2. |
Interval tool sound is still behaving correctly on reset and the code looks good. Nice improvement. Marking to cherry-pick. |
(cherry picked from commit d9a59d5)
Please close after verifying. |
I had a fairly bad instance of freezing with multitouch. I saw it on iPad, and don't have a touch screen on my computer, so I don't have a console readout. Steps:
RPReplay_Final1714416250.MP4 |
Continuing multitouch behavior in #321. This issue can be closed. |
In phetsims/tambo#190 I added a static
isResettingAllProperty
flag toResetAllButton
. In subsequently looking through the codebase for opportunities to use it, I found the fileisResettingAllProperty.ts
in projectile-data-lab. I though y'all might want to know that there is now a common code version of this that might be a suitable replacement.The text was updated successfully, but these errors were encountered: