Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use SCENERY_PHET/NumberDisplay #96

Closed
pixelzoom opened this issue Feb 3, 2020 · 3 comments
Closed

use SCENERY_PHET/NumberDisplay #96

pixelzoom opened this issue Feb 3, 2020 · 3 comments
Assignees
@pixelzoom
Labels
dev:phet-io meeting:design

Comments

@pixelzoom
Copy link
Contributor

Related to #92...

The pH meters in Macro and Micro screens should be using NumberDisplay. Ditto for the displays on the graph. They predate NumberDisplay, so have their own implementation to display the value. This is important for phet-io and a11y.
@pixelzoom pixelzoom self-assigned this Feb 3, 2020
@pixelzoom pixelzoom mentioned this issue Feb 4, 2020
Closed
@pixelzoom pixelzoom removed their assignment Feb 4, 2020
@pixelzoom pixelzoom changed the title use NumberDisplay use SCENERY_PHET/NumberDisplay Feb 5, 2020
pixelzoom added a commit that referenced this issue Feb 6, 2020
@pixelzoom
use NumberDisplay in PHMeterNode, #96
a4c74ab
@pixelzoom
Copy link
Contributor Author

pixelzoom commented Feb 6, 2020 •
edited
Loading

I changed PHMeterNode to use NumberDisplay, and that went smoothly.

Changing GraphIndicatorNode is not as easy. It displays values in scientific notation (e.g. "1 x 10-7"), and that's not supported by NumberDisplay. So I'm going to put that on hold until we see what phet-io instrumentation (if any) is needed for GraphIndicatorNode.

Still to do: use NumberDisplay in MacroPHMeterNode.

@pixelzoom pixelzoom self-assigned this Feb 6, 2020
pixelzoom added a commit that referenced this issue Feb 6, 2020
@pixelzoom
TODO #96
8083ef4
pixelzoom added a commit that referenced this issue Feb 6, 2020
@pixelzoom
instrument NumberDisplay in PHMeterNode, #96
3e4a998
pixelzoom added a commit that referenced this issue Feb 6, 2020
@pixelzoom
TODO #96
5ae5e65
@pixelzoom
Copy link
Contributor Author

GraphIndicatorNode's display is not necessary to instrument. Over in #105, the Properties that contain the values were instrumented. So I'm not going to attempt to use NumberDisplay there.

pixelzoom added a commit to phetsims/ph-scale-basics that referenced this issue Feb 7, 2020
@pixelzoom
use NumberDisplay in MacroPHMeterNode, phetsims/ph-scale#96
7227fda
pixelzoom added a commit that referenced this issue Feb 7, 2020
@pixelzoom
use NumberDisplay in MacroPHMeterNode, #96
c494c9b
pixelzoom added a commit to phetsims/ph-scale-basics that referenced this issue Feb 7, 2020
@pixelzoom
combine MacroPHMeterNode.PHIndicatorNode and ValueNode, phetsims/ph-s…
c313797 
…cale#96
pixelzoom added a commit that referenced this issue Feb 7, 2020
@pixelzoom
combine MacroPHMeterNode.PHIndicatorNode and ValueNode, #96
72003ac
pixelzoom added a commit to phetsims/ph-scale-basics that referenced this issue Feb 7, 2020
@pixelzoom
make pH probe visibleProperty read-only, phetsims/ph-scale#96
09e8db4
pixelzoom added a commit that referenced this issue Feb 7, 2020
@pixelzoom
make pH probe visibleProperty read-only, #96
95679d6
@pixelzoom
Copy link
Contributor Author

MacroPHMeterNode has been changed to use NumberDisplay, and refactored to have this structure:

screenshot_105

Closing.

@pixelzoom pixelzoom mentioned this issue May 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pixelzoom pixelzoom

Labels
dev:phet-io meeting:design
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pixelzoom