-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "Item" suffix to Solute combo box items #195
Comments
@arouinfar please review the changes to the client guides for ph-scale and ph-scale-basics. They have been pushed to master, ph-scale 1.4, and ph-scale-basics 1.4. If they look OK, you can unassign yourself and reassigned to me. Thanks. |
ComboBoxItem change is phetsims/sun@187ac98 and has been cherry-picked to ph-scale 1.4 and ph-scale-basics 1.4. |
Cherry-picked phetsims/sun@55c4fc0, which improves the error message for the assertion in ComboBoxItem. |
@pixelzoom the changes are all looking good in master. I reviewed the tree, client guides, and checked that relevant elements remained phetioFeatured. |
Ready for testing in next RC. To verify:
|
Win 10 Chrome 1.5.0-dev.1 #195 (comment) looks ok. Closing |
Over in phetsims/sun#615, it was decided that elements in a group should still have a tandem name that indicates their type.
In pH Scale, the combo box items under
soluteComboBox.listBox
should all have an "Item" suffix. Doing this by concatenating "Item" onto the solute tandemName is OK.TODO list:
The text was updated successfully, but these errors were encountered: