Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tandem.REQUIRED is no longer checked #183

Closed
pixelzoom opened this issue Jul 23, 2020 · 3 comments
Closed

Tandem.REQUIRED is no longer checked #183

pixelzoom opened this issue Jul 23, 2020 · 3 comments
Labels
dev:phet-io type:bug

Comments

@pixelzoom
Copy link
Contributor

Need a fix for phetsims/tandem#192.
@pixelzoom pixelzoom mentioned this issue Jul 23, 2020
Closed
pixelzoom added a commit that referenced this issue Jul 27, 2020
@pixelzoom
phetsims/tandem#192, #183
4be986f
pixelzoom added a commit to phetsims/ph-scale-basics that referenced this issue Jul 27, 2020
@pixelzoom
phetsims/tandem#192, phetsims/ph-scale#183
17d5508
@pixelzoom
Copy link
Contributor Author

pixelzoom commented Jul 27, 2020 •
edited
Loading

A workaround was devised for phetsims/tandem#192., see phetsims/tandem#192 (comment). That workaround has been cherry-picked. Ready for testing in the next RC, by running the standalone PhET-iO version with ?phetioValidation=true.

@pixelzoom
Copy link
Contributor Author

pixelzoom commented Aug 4, 2020 •
edited
Loading

To verify in the next RC:

  1. Run the sim in Studio with ?phetioValidation=true
  2. Verify that there are no console errors

This was referenced Aug 6, 2020
Closed
Closed
This was referenced Aug 17, 2020
Closed
Closed
@pixelzoom pixelzoom mentioned this issue May 12, 2021
Closed
19 tasks
@loganbraywork
Copy link

Seems to be working as intended on both Chrome and Firefox for windows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dev:phet-io type:bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pixelzoom @loganbraywork