-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Faucet knobs don't have indicated pointer areas #180
Comments
The faucet (FaucetNode) is a common-code UI component. @KatieWoe can you reproduce this on other sims that have faucets? (BLL, EFAC, FPAF, Wave Interference) |
Looks like it does happen in other sims on master. |
Is the problem only with mouseArea (blue) or is it also a problem with touchArea (red)? |
Only seeing it with mouse, but then touch has snag to pick up, so it would be pretty hard to see it if it were an issue. |
This is a common-code problem, tracking in phetsims/scenery-phet#614. Labeling this issue as "on hold" until phetsims/scenery-phet#614 is fixed. |
@KatieWoe if the touchArea were incorrect, then you wouldn't be able to snag in the bottom part of the touchArea. |
@KatieWoe it looks to me like touchArea is also broken. Testing ph-scale 1.4.0-rc.1 on iPad6, I can't snag in the bottom part of the touchArea. |
phetsims/scenery-phet#614 is resolved and the fix has been cherry-picked. Ready for regression testing in next RC. |
To verify in the next RC:
|
Works on Chromebook. |
Thanks @brooklynlash. @KatieWoe are you planning to test on other platforms, or can this be closed? |
It didn't seem to be platform dependent, so I think it can be closed. |
Test device
Jordan and Dell
Operating System
Mac 10.14 and Win 10
Browser
Safari and Chrome
Problem description
For phetsims/qa#514 and phetsims/qa#515. Occurs in published.
The blue knobs for the water and drain faucets do not seem to be grabable all over. The location where it stops being grabable seems to on the lower half of the knob. It can be seen by when the mouse is an arrow and when it is a hand.
Visuals
Troubleshooting information:
!!!!! DO NOT EDIT !!!!!
Name: pH Scale
URL: https://phet-dev.colorado.edu/html/ph-scale/1.4.0-rc.1/phet/ph-scale_all_phet.html?showPointerAreas
Version: 1.4.0-rc.1 2020-07-09 22:04:23 UTC
Features missing: touch
Flags: pixelRatioScaling
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/84.0.4147.89 Safari/537.36
Language: en-US
Window: 1536x722
Pixel Ratio: 2.5/1
WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium)
GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium)
Vendor: WebKit (WebKit WebGL)
Vertex: attribs: 16 varying: 30 uniform: 4096
Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32)
Max viewport: 32767x32767
OES_texture_float: true
Dependencies JSON: {}
The text was updated successfully, but these errors were encountered: