Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faucet knobs don't have indicated pointer areas #180

Closed
KatieWoe opened this issue Jul 22, 2020 · 12 comments
Closed

Faucet knobs don't have indicated pointer areas #180

KatieWoe opened this issue Jul 22, 2020 · 12 comments
Assignees
Labels

Comments

@KatieWoe
Copy link
Contributor

Test device
Jordan and Dell
Operating System
Mac 10.14 and Win 10
Browser
Safari and Chrome
Problem description
For phetsims/qa#514 and phetsims/qa#515. Occurs in published.
The blue knobs for the water and drain faucets do not seem to be grabable all over. The location where it stops being grabable seems to on the lower half of the knob. It can be seen by when the mouse is an arrow and when it is a hand.

Visuals
knobnotallthere

Troubleshooting information:

!!!!! DO NOT EDIT !!!!!
Name: ‪pH Scale‬
URL: https://phet-dev.colorado.edu/html/ph-scale/1.4.0-rc.1/phet/ph-scale_all_phet.html?showPointerAreas
Version: 1.4.0-rc.1 2020-07-09 22:04:23 UTC
Features missing: touch
Flags: pixelRatioScaling
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/84.0.4147.89 Safari/537.36
Language: en-US
Window: 1536x722
Pixel Ratio: 2.5/1
WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium)
GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium)
Vendor: WebKit (WebKit WebGL)
Vertex: attribs: 16 varying: 30 uniform: 4096
Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32)
Max viewport: 32767x32767
OES_texture_float: true
Dependencies JSON: {}

@pixelzoom
Copy link
Contributor

pixelzoom commented Jul 22, 2020

The faucet (FaucetNode) is a common-code UI component. @KatieWoe can you reproduce this on other sims that have faucets? (BLL, EFAC, FPAF, Wave Interference)

@pixelzoom pixelzoom assigned KatieWoe and unassigned pixelzoom Jul 22, 2020
@pixelzoom pixelzoom changed the title Knobs don't have indicated pointer areas Faucet knobs don't have indicated pointer areas Jul 22, 2020
@KatieWoe
Copy link
Contributor Author

Looks like it does happen in other sims on master.

@pixelzoom
Copy link
Contributor

Is the problem only with mouseArea (blue) or is it also a problem with touchArea (red)?

@KatieWoe
Copy link
Contributor Author

Only seeing it with mouse, but then touch has snag to pick up, so it would be pretty hard to see it if it were an issue.

@pixelzoom
Copy link
Contributor

This is a common-code problem, tracking in phetsims/scenery-phet#614.

Labeling this issue as "on hold" until phetsims/scenery-phet#614 is fixed.

@pixelzoom
Copy link
Contributor

@KatieWoe if the touchArea were incorrect, then you wouldn't be able to snag in the bottom part of the touchArea.

@pixelzoom
Copy link
Contributor

pixelzoom commented Jul 22, 2020

@KatieWoe it looks to me like touchArea is also broken. Testing ph-scale 1.4.0-rc.1 on iPad6, I can't snag in the bottom part of the touchArea.

pixelzoom added a commit that referenced this issue Jul 23, 2020
pixelzoom added a commit to phetsims/ph-scale-basics that referenced this issue Jul 23, 2020
@pixelzoom
Copy link
Contributor

phetsims/scenery-phet#614 is resolved and the fix has been cherry-picked.

Ready for regression testing in next RC.

@pixelzoom
Copy link
Contributor

pixelzoom commented Aug 4, 2020

To verify in the next RC:

  1. Run the sim with ?showPointerAreas
  2. Verify that the mouseArea and touchArea work as expected for the faucets on the Macro screen (no need to do Micro screen)

@brooklynlash
Copy link

Works on Chromebook.

@pixelzoom
Copy link
Contributor

Thanks @brooklynlash.

@KatieWoe are you planning to test on other platforms, or can this be closed?

@KatieWoe
Copy link
Contributor Author

It didn't seem to be platform dependent, so I think it can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants