-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move our typescript system to perennial #364
Comments
Looking at this now. |
Signed-off-by: Michael Kauzmann <[email protected]>
Signed-off-by: Michael Kauzmann <[email protected]>
Signed-off-by: Michael Kauzmann <[email protected]>
Signed-off-by: Michael Kauzmann <[email protected]>
|
Most steps done, I'll check in with @zepumph and we cannot do final steps until merge to main. |
|
Signed-off-by: Michael Kauzmann <[email protected]>
Signed-off-by: Michael Kauzmann <[email protected]>
This reverts commit 81ff4ea.
All that is left here:
|
Signed-off-by: Michael Kauzmann <[email protected]>
I moved tsconfig/buildtools/ back to chipper. While I was here I converted copy-history-to-repo from *.js to *.ts and ran it with sage run. Closing. |
We still have TODOs, pointing here. Reopening. |
I addressed the TODO in the commit. buildtools/tsconfig.json was already in chipper (and used), we just needed to remove the leftover one in perennial. Closing. |
Signed-off-by: Michael Kauzmann <[email protected]>
From phetsims/chipper#1464. Instead of using tsc from chipper, we need this to be in perennial so we can use typescript in perennial.
Also phet-core/types should move to perenniallet's chat in How/Should perennial be able to use code from phet-core, like IntentionalAny? #371grunt check --all
chipper#1487tsc
and move to perennial. Usegrunt check
tooDelete chipper/tsconfig/ and point all usage sites to perennial-aliasUPDATE: Chipper and buildtools config should live in chipper.The text was updated successfully, but these errors were encountered: