Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move chipper/eslint/ to perennial #1500

Closed
zepumph opened this issue Oct 18, 2024 · 4 comments
Closed

Move chipper/eslint/ to perennial #1500

zepumph opened this issue Oct 18, 2024 · 4 comments
Labels
status:ready-for-review

Comments

@zepumph
Copy link
Member

zepumph commented Oct 18, 2024

Side issue for #1489.

These are shared config files and phet-specific rules.
This will mostly just be busy work, but could break scenery stack linting, since the relative path may change.
@zepumph zepumph self-assigned this Oct 18, 2024
@github-project-automation github-project-automation bot moved this to Upcoming Tests (by priority) in QA Pipeline Oct 18, 2024
@zepumph zepumph removed this from QA Pipeline Oct 18, 2024
@zepumph
Copy link
Member Author

zepumph commented Oct 18, 2024

The highest priority piece of this issue is that perennial's eslint.config.mjs depends on chipper:

https://github.com/phetsims/perennial/blob/791db377e0a5e594bcd1ba36149b579dc3d9f0a4/eslint.config.mjs#L3

@zepumph zepumph mentioned this issue Oct 18, 2024
Closed
@zepumph
Copy link
Member Author

zepumph commented Oct 18, 2024 •
edited
Loading

  • This issue includes all the linting config plugins and packages in chipper/package.json.

@zepumph
Copy link
Member Author

zepumph commented Oct 21, 2024 •
edited
Loading

  • Let's use paths to perennial-alias always. Like import getNodeConfiguration from '../perennial/eslint/getNodeConfiguration.mjs';
  • Let's move this to be under perennial/js/eslint/

@zepumph zepumph assigned samreid and unassigned zepumph Oct 21, 2024
zepumph added a commit that referenced this issue Oct 22, 2024
@zepumph
delete chipper/eslint/ (copied to perennial), #1500
20783d8 
Signed-off-by: Michael Kauzmann <[email protected]>
zepumph added a commit that referenced this issue Oct 22, 2024
@zepumph
move lint config packages to perennial, #1500
50885ef 
Signed-off-by: Michael Kauzmann <[email protected]>
zepumph added a commit that referenced this issue Oct 22, 2024
@zepumph
move lint config packages to perennial, #1500
6aa1eab
zepumph added a commit to phetsims/perennial that referenced this issue Oct 22, 2024
@zepumph
move eslint/ to js/ directory, phetsims/chipper#1500
c30bd5e 
Signed-off-by: Michael Kauzmann <[email protected]>
zepumph added a commit to phetsims/perennial that referenced this issue Oct 22, 2024
@zepumph
delete chipper/eslint/ (copied to perennial), phetsims/chipper#1500
12116a4 
Signed-off-by: Michael Kauzmann <[email protected]>
zepumph added a commit to phetsims/perennial that referenced this issue Oct 22, 2024
@zepumph
move lint config packages to perennial, phetsims/chipper#1500
62ef092 
Signed-off-by: Michael Kauzmann <[email protected]>
zepumph added a commit to phetsims/perennial that referenced this issue Oct 22, 2024
@zepumph
move lint config packages to perennial, phetsims/chipper#1500
d65fedb
zepumph added a commit to phetsims/perennial that referenced this issue Oct 22, 2024
@zepumph
fix eslint/ dir now that it lives in perennial (move phet-types), phe…
ba275ee 
…tsims/chipper#1500
zepumph added a commit to phetsims/perennial that referenced this issue Oct 22, 2024
@zepumph
recommit things that were not copied over from chipper, #364 phetsims…
5b52996 
…/chipper#1500 phetsims/chipper#1492
zepumph added a commit that referenced this issue Oct 22, 2024
@zepumph
fix package for chipper, #1500
75cb07b
zepumph added a commit to phetsims/perennial that referenced this issue Oct 22, 2024
@zepumph
recommit things that were not copied over from chipper, #364 phetsims…
c4f5da2 
…/chipper#1500 phetsims/chipper#1492
@zepumph zepumph mentioned this issue Oct 22, 2024
Closed
zepumph added a commit to phetsims/perennial that referenced this issue Oct 23, 2024
@zepumph
remove phet-io-require-contains-ifphetio.js, phetsims/chipper#1500
5a091c3
@zepumph
Copy link
Member Author

zepumph commented Oct 23, 2024

Merged to main. There are no more TODOs or work for this issue. Closing

@zepumph zepumph closed this as completed Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status:ready-for-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@samreid @zepumph