Skip to content

Commit

Permalink
Remove unnecessary type assertions, see phetsims/chipper#1238
Browse files Browse the repository at this point in the history
  • Loading branch information
samreid authored and zepumph committed Oct 22, 2024
1 parent 7721315 commit cb9ae63
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion eslint/.eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ module.exports = {
'@typescript-eslint/no-unnecessary-type-arguments': 'off', // TODO: Enable this rule

// Disallow type assertions that do not change the type of an expression ✅ 🔧 💭
'@typescript-eslint/no-unnecessary-type-assertion': 'off',
'@typescript-eslint/no-unnecessary-type-assertion': 'off', // TODO: This rule catches some good problems which I committed, but it also breaks in Screen.ts (rule doesn't work as it should)

// Disallow unnecessary constraints on generic types ✅ 🛠
'@typescript-eslint/no-unnecessary-type-constraint': 'error',
Expand Down

0 comments on commit cb9ae63

Please sign in to comment.