Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
  • Loading branch information
samreid authored and zepumph committed Oct 22, 2024
1 parent 7ab90bb commit 7721315
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions eslint/.eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -95,10 +95,10 @@ module.exports = {
'@typescript-eslint/consistent-type-definitions': 'off', // TODO: Discuss as a team. Assign a champion to investigate the differences and describe them to the team. 667 failures. There are subtle differences between type and interface and I'm not sure we want to limit ourselves, even though we mostly use type at the moment. Interfaces can be extended which may be important.... or is it confusing????

// Enforce consistent usage of type exports 🔧 💭
'@typescript-eslint/consistent-type-exports': 'off', // TODO: Discuss as a team and probably enable. Can we get WebStorm to automatically `import type`? If not, it may be too much hassle. Also check if it gives a performance boost. This purportedly enables some tsc optimizations. But is it a hassle if WebStorm or other IDEs don't follow this pattern by default?
'@typescript-eslint/consistent-type-exports': 'off', // We did not observe a performance boost, nor do we see a significant benefit from this rule. See https://github.com/phetsims/chipper/issues/1283

// Enforce consistent usage of type imports 🔧
'@typescript-eslint/consistent-type-imports': 'off', // TODO: Discuss as a team and probably enable. Can we get WebStorm to automatically `import type`? If not, it may be too much hassle. Also check if it gives a performance boost. This purportedly enables some tsc optimizations. But is it a hassle if WebStorm or other IDEs don't follow this pattern by default?
'@typescript-eslint/consistent-type-imports': 'off', // We did not observe a performance boost, nor do we see a significant benefit from this rule. See https://github.com/phetsims/chipper/issues/1283

// Require explicit return types on functions and class methods
'@typescript-eslint/explicit-function-return-type': 'off', // We want to use inference on local arrow functions. We use explicit-method-return-type for the important cases.
Expand Down

0 comments on commit 7721315

Please sign in to comment.