Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change '{0}' to SunConstants.VALUE_NAMED_PLACEHOLDER #210

Open
pixelzoom opened this issue Feb 5, 2019 · 1 comment
Open

change '{0}' to SunConstants.VALUE_NAMED_PLACEHOLDER #210

pixelzoom opened this issue Feb 5, 2019 · 1 comment

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented Feb 5, 2019

Noted in phetsims/scenery-phet#446 (comment).

Since NumberDisplay and NumberControl now support {{value}}, there are 4 replacements involving '{0}' that should be changed to NumberDisplay.NAMED_PLACEHOLDER:

screenshot_1029

In the future, such replacements could be avoided altogether by using '{{value}}' in the string file. For example:

// instead of this:
  "metersPattern": {
    "value": "{{meters}} m"
  },

// use this:
  "metersPattern": {
    "value": "{{value}} m"
  },
@pixelzoom pixelzoom changed the title change '{0}' to NumberDisplay.NAMED_PLACEHOLDER change '{0}' to SunConstants.VALUE_NAMED_PLACEHOLDER Feb 7, 2019
@pixelzoom
Copy link
Contributor Author

pixelzoom commented Feb 7, 2019

This constant was moved to SunConstants.VALUE_NAMED_PLACEHOLDER in phetsims/sun#474.

pixelzoom added a commit that referenced this issue Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants