Skip to content

Commit

Permalink
add TODOs #210
Browse files Browse the repository at this point in the history
  • Loading branch information
pixelzoom committed Feb 7, 2019
1 parent c9924f4 commit 06e9c07
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 0 deletions.
1 change: 1 addition & 0 deletions js/common/view/FrictionSliderNode.js
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ define( function( require ) {
// range the slider can have
var sliderValueRange = new Range( frictionToSliderValue( frictionRange.min ), frictionToSliderValue( frictionRange.max ) );

//TODO #210 replace '{0}' with SunConstants.VALUE_NAMED_PLACEHOLDER
var numberControl = new PendulumNumberControl( frictionString, sliderValueProperty, sliderValueRange, '{0}', 'rgb(50,145,184)', {
hasReadoutProperty: new BooleanProperty( false ),
excludeTweakers: true,
Expand Down
1 change: 1 addition & 0 deletions js/common/view/GravityControlNode.js
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ define( function( require ) {
useTextSliderLabels: true
}, options );

//TODO #210 replace '{0}' with SunConstants.VALUE_NAMED_PLACEHOLDER
var labelPattern = StringUtils.fillIn( gravitationalAccelerationPatternString, {
gravity: '{0}'
} );
Expand Down
1 change: 1 addition & 0 deletions js/common/view/PendulumControlPanel.js
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ define( function( require ) {
pendulumNumber: pendulumNumberString
} );

//TODO #210 replace '{0}' with SunConstants.VALUE_NAMED_PLACEHOLDER
var lengthPattern = StringUtils.fillIn( metersPatternString, { meters: '{0}' } );
var massPattern = StringUtils.fillIn( kilogramsPatternString, { kilograms: '{0}' } );

Expand Down

0 comments on commit 06e9c07

Please sign in to comment.