-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Population graph should not display "Zoom out..." message when all checkboxes are unchecked #213
Comments
I addressed this in the above commit, which can be test-driven in 1.2.0-dev.1. To test:
|
Assuming this tests OK, this will be picked up by the 1.1 prototype. #209 blocks the prototype, and this fix also fixes that issue. |
Yes indeed, a horizontal line at y=0 is easy to miss. The only way around this would be to make the line thicker for all plotted data, which I think would compromise the overall look of the graph. |
4affe22 has been cherry-picked into the 1.1 branch. |
Fix verified 1.2.0-dev.1. |
Ready for RC testing in phetsims/qa#542. See #213 (comment) for steps to verify. |
Fix verified in 1.1.0-rc2 |
Noticed with working on #209. If none of the Population checkboxes are checked, then the graph is displaying nothing. In this case, it's not appropriate to display "Zoom out to show data", but we are.
This will not be addressed in the prototype RC.
The text was updated successfully, but these errors were encountered: