Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Population graph should not display "Zoom out..." message when all checkboxes are unchecked #213

Closed
pixelzoom opened this issue Aug 28, 2020 · 8 comments
Assignees
Labels

Comments

@pixelzoom
Copy link
Contributor

Noticed with working on #209. If none of the Population checkboxes are checked, then the graph is displaying nothing. In this case, it's not appropriate to display "Zoom out to show data", but we are.

This will not be addressed in the prototype RC.

@pixelzoom
Copy link
Contributor Author

I addressed this in the above commit, which can be test-driven in 1.2.0-dev.1. To test:

  1. Run the sim
  2. Go to ether screen
  3. Zoom the Population graph in fully, so the y-axis range is [0,5]
  4. Press the "Add a Mate" button.
  5. Wait for bunnies to take over the world, close the dialog
  6. Verify that "Zoom in to see data" appears in the graph
  7. Toggle "Total" checkbox (and other checkboxes) off and on. Verify that "Zoom..." only appears in the graph when there is no data visible and at least 1 checkbox is checked.

@pixelzoom
Copy link
Contributor Author

Assuming this tests OK, this will be picked up by the 1.1 prototype. #209 blocks the prototype, and this fix also fixes that issue.

@amanda-phet
Copy link
Contributor

It seems to be working correctly!

One thing I want documented:

First, I have total and white fur checked (can just be one checkbox though). It looks like this:
image

Then when I click brown fur, the "zoom out" text goes away, but it's hard to tell that there is visible data for brown fur.
image

Just wanted this documented. Nothing is wrong, the code is correct, but it took me a few clicks to realize that there was data because it is subtle.

@amanda-phet amanda-phet removed their assignment Aug 31, 2020
@pixelzoom
Copy link
Contributor Author

Yes indeed, a horizontal line at y=0 is easy to miss. The only way around this would be to make the line thicker for all plotted data, which I think would compromise the overall look of the graph.

@pixelzoom
Copy link
Contributor Author

4affe22 has been cherry-picked into the 1.1 branch.

@ariel-phet
Copy link

Fix verified 1.2.0-dev.1.

@pixelzoom
Copy link
Contributor Author

pixelzoom commented Sep 1, 2020

Ready for RC testing in phetsims/qa#542. See #213 (comment) for steps to verify.

@ariel-phet
Copy link

Fix verified in 1.1.0-rc2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants