Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Review: add implementation-notes.md #97

Closed
AgustinVallejo opened this issue Mar 9, 2023 · 5 comments
Closed

Code Review: add implementation-notes.md #97

AgustinVallejo opened this issue Mar 9, 2023 · 5 comments
Assignees
@AgustinVallejo
Labels
dev:code-review status:ready-for-review

Comments

@AgustinVallejo
Copy link
Contributor

For #88
@AgustinVallejo AgustinVallejo self-assigned this Mar 9, 2023
@AgustinVallejo AgustinVallejo mentioned this issue Mar 9, 2023
Closed
74 tasks
@jonathanolson
Copy link
Contributor

Assign me once this is done for review (I'll also be available to help create it, if so that won't be needed)

samreid added a commit that referenced this issue Mar 16, 2023
@samreid
Initial notes for implementation-notes.md, see #97
256834c
@samreid
Copy link
Member

samreid commented Mar 16, 2023

I started on that file, but it could use more help.

samreid added a commit that referenced this issue Mar 16, 2023
@samreid
Add notes about memory, see #97
cdd2a9b
AgustinVallejo added a commit that referenced this issue Mar 17, 2023
@AgustinVallejo
Add implementation-notes.md, see #97
15772aa
@AgustinVallejo AgustinVallejo mentioned this issue Mar 17, 2023
Closed
@AgustinVallejo
Copy link
Contributor Author

I believe this, as well as #96 are ready for review

jonathanolson added a commit that referenced this issue Mar 18, 2023
@jonathanolson
Corrections for implementation notes, adding note about ViewSynchroni…
c60b70a 
…zers, see #97
@jonathanolson
Copy link
Contributor

Looks good, can you review the above change (and if that's good, close?)

@AgustinVallejo
Copy link
Contributor Author

It's good, closing. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AgustinVallejo AgustinVallejo

Labels
dev:code-review status:ready-for-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jonathanolson @samreid @AgustinVallejo