-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code Review: Add model.md #96
Comments
Assign me once this is done for review (I'll also be available to help create it, if so that won't be needed) |
@AgustinVallejo said this is ready for review. @jonathanolson can you please take a look? |
I believe this, along #97 are ready for review |
I think it would be good to put the Lab mode configurations into the model.md, so that people can see what coordinates they start with (without being rounded at all). Since we're setting them in "model" units, they would be getting rounded "view" units. |
Oops, actually, they're referenced! We'll need to not break that link. |
Made some changes above, can you review? Additionally, I think it would be good to mention some things about collisions. Does it preserve momentum? |
Looks good, just the one item above! |
Added a big section with Physical Simplifications, to adress body sizes, mass scales, collisions, and how accurate is each pre-set with their real world counterparts. So another fast review would be nice. |
This is excellent! My only question would be whether the "Distances and Sizes" and "Radii of Bodies" are really separate - they are both talking about the radii/size (same thing?), and might be combinable. |
I think they work good separately, because one section is stating that body sizes are actually way bigger than in reality, the other one states that we are using a particular mapping function between mass and radii. Closing. |
For #88
The text was updated successfully, but these errors were encountered: