Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle REVIEW comments in my-solar-system/solar-system-common #95

Closed
jonathanolson opened this issue Mar 9, 2023 · 5 comments
Closed

Handle REVIEW comments in my-solar-system/solar-system-common #95

jonathanolson opened this issue Mar 9, 2023 · 5 comments
Assignees
@AgustinVallejo
Labels
dev:code-review status:ready-for-review

Comments

@jonathanolson
Copy link
Contributor

Creating an issue so it's easier to track.
@jonathanolson
Copy link
Contributor Author

I believe I've completed adding notes, based on all of the changed commits since I last reviewed.

@samreid
Copy link
Member

samreid commented Mar 10, 2023

For unknown reasons, I tracked some of this work in #88

jonathanolson added a commit that referenced this issue Mar 10, 2023
@jonathanolson
ComboBox refactor handling REVIEWs, see #95
e1d161b
jonathanolson added a commit that referenced this issue Mar 10, 2023
@jonathanolson
MySolarSystemComboBox => LabModeComboBox, see #95
13c026c
jonathanolson added a commit that referenced this issue Mar 10, 2023
@jonathanolson
Moving client-belonging options from LabModeComboBox out, see #95
216e680
samreid added a commit that referenced this issue Mar 15, 2023
@samreid
Add review comment, see #95
17a29c7
samreid added a commit that referenced this issue Mar 15, 2023
@samreid
Add review comment, see #95
8c5084f
This was referenced Mar 15, 2023
Closed
Closed
samreid added a commit that referenced this issue Mar 15, 2023
@samreid
Rename MAX_WIDTH to TEXT_MAX_WIDTH and document, see #95
263094e
samreid added a commit to phetsims/solar-system-common that referenced this issue Mar 15, 2023
@samreid
Rename MAX_WIDTH to TEXT_MAX_WIDTH and document, see phetsims/my-sola…
e330bfe 
…r-system#95
samreid added a commit to phetsims/keplers-laws that referenced this issue Mar 15, 2023
@samreid
Rename MAX_WIDTH to TEXT_MAX_WIDTH and document, see phetsims/my-sola…
5fdd099 
…r-system#95
AgustinVallejo added a commit to phetsims/solar-system-common that referenced this issue Mar 15, 2023
@AgustinVallejo
Handling review comments, phetsims/my-solar-system#95
6a4f000
AgustinVallejo added a commit that referenced this issue Mar 15, 2023
@AgustinVallejo
Handling review comments, #95
94236de
samreid added a commit to phetsims/solar-system-common that referenced this issue Mar 16, 2023
@samreid
Remove NumberDisplay parts of SolarSystemCommonTextNumberDisplay, see p…
6935e3e 
…hetsims/my-solar-system#95
samreid added a commit to phetsims/solar-system-common that referenced this issue Mar 16, 2023
@samreid
Rename combinePowerString=>createPowerStringProperty phetsims/my-sola…
d8361ec 
…r-system#95
samreid added a commit to phetsims/keplers-laws that referenced this issue Mar 16, 2023
@samreid
Rename combinePowerString=>createPowerStringProperty phetsims/my-sola…
ce7d65b 
…r-system#95
samreid added a commit to phetsims/keplers-laws that referenced this issue Mar 16, 2023
@samreid
Rename SolarSystemCommonTextNumberDisplay=>SolarSystemCommonTextUtils p…
0d0ba8a 
…hetsims/my-solar-system#95
samreid added a commit to phetsims/solar-system-common that referenced this issue Mar 16, 2023
@samreid
Rename SolarSystemCommonTextNumberDisplay=>SolarSystemCommonTextUtils p…
08224a9 
…hetsims/my-solar-system#95
samreid added a commit to phetsims/solar-system-common that referenced this issue Mar 16, 2023
@samreid
Move SolarSystemCommonTextUtils to keplers law, see phetsims/my-solar…
d89947b 
…-system#95
samreid pushed a commit to phetsims/keplers-laws that referenced this issue Mar 16, 2023
@AgustinVallejo
Handling review comments, phetsims/my-solar-system#95
4265d91
samreid added a commit to phetsims/keplers-laws that referenced this issue Mar 16, 2023
@samreid
Remove NumberDisplay parts of SolarSystemCommonTextNumberDisplay, see p…
f294003 
…hetsims/my-solar-system#95
samreid added a commit to phetsims/keplers-laws that referenced this issue Mar 16, 2023
@samreid
Rename combinePowerString=>createPowerStringProperty phetsims/my-sola…
35679be 
…r-system#95
samreid added a commit to phetsims/keplers-laws that referenced this issue Mar 16, 2023
@samreid
Rename SolarSystemCommonTextNumberDisplay=>SolarSystemCommonTextUtils p…
7396404 
…hetsims/my-solar-system#95
samreid added a commit to phetsims/keplers-laws that referenced this issue Mar 16, 2023
@samreid
Move SolarSystemCommonTextUtils to keplers law, see phetsims/my-solar…
e60196d 
…-system#95
@samreid
Copy link
Member

samreid commented Mar 16, 2023

All REVIEW comments complete. @AgustinVallejo can you please review?

@samreid
Copy link
Member

samreid commented Mar 16, 2023

I also moved one string utility to Kepler's Law since it was not used in Solar System Common or My Solar System.

@AgustinVallejo
Copy link
Contributor

This is looking good, thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AgustinVallejo AgustinVallejo

Labels
dev:code-review status:ready-for-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jonathanolson @samreid @AgustinVallejo